Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Include declared_path in 'No podspec found..' error message for PathSource #1832

Merged
merged 1 commit into from

3 participants

@ericallam

Fixes issue #1825:

Turns this error output:

Fetching podspec for `QMBParallaxScrollViewController` from `../QMBParallaxScrolViewController`
[!] No podspec found for `QMBParallaxScrollViewController` in ``

Into this:

Fetching podspec for `QMBParallaxScrollViewController` from `../QMBParallaxScrolViewController`
[!] No podspec found for `QMBParallaxScrollViewController` in `../QMBParallaxScrolViewController`
@Kapin
Collaborator

LGTM. I'll let @orta give the final thumbs up.

@orta
Owner

Do it. Thanks @ericallam !

@orta orta merged commit a88e48f into CocoaPods:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
2  lib/cocoapods/external_sources.rb
@@ -378,7 +378,7 @@ def podspec_path
pathname = Pathname.new(absolute_path)
unless pathname.exist?
- raise Informative, "No podspec found for `#{name}` in `#{params[:local]}`"
+ raise Informative, "No podspec found for `#{name}` in `#{declared_path}`"
end
pathname
end
View
2  spec/unit/external_sources_spec.rb
@@ -295,7 +295,7 @@ module Pod
it "raises if the podspec cannot be found" do
@external_source.stubs(:params).returns(:path => temporary_directory)
e = lambda { @external_source.send(:podspec_path) }.should.raise Informative
- e.message.should.match /No podspec found/
+ e.message.should.match /No podspec found for `Reachability` in `#{temporary_directory}`/
end
end
end
Something went wrong with that request. Please try again.