Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Include a space between `-isystem` and the directory #1894

Closed
wants to merge 1 commit into from

3 participants

@kylef
Owner

According to clang's help it should have a space.

-isystem <directory>    Add directory to SYSTEM include search path

Closes #1862

@kylef kylef Include a space between `-isystem` and the directory
According to clang's help it should have a space.

    -isystem <directory>    Add directory to SYSTEM include search path

Closes #1862
b1cb6f7
@kylef
Owner

Oops, I was only running the functional tests. I need to fix the fixtures elsewhere!

@fabiopelosin

@kylef other than the fixtures is it safe to merge this?

@kylef
Owner

I think so, unless it breaks anything. It is correct they should have a space?

@CocoaPodsBot CocoaPodsBot was assigned by kylef
@CocoaPodsBot CocoaPodsBot was unassigned by kylef
@kylef kylef self-assigned this
@fabiopelosin

This can be safely merged after testing the patch with a reasonably complex Podfile and checking that it builds

@kylef
Owner

@irrationalfab Turns out @alloy has a better fix in d8c67f2 which should instead be pulled over.

@fabiopelosin

@alloy can we just cherry pick?

@kylef
Owner

@irrationalfab yes, I was trying to fix the broken build beforehand.

@fabiopelosin

Nice! I'm cherry-picking it!

@fabiopelosin

Closed by 24fcf6b

@kylef
Owner

:+1: awesome thanks!

@kylef kylef deleted the isystem branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 16, 2014
  1. @kylef

    Include a space between `-isystem` and the directory

    kylef authored
    According to clang's help it should have a space.
    
        -isystem <directory>    Add directory to SYSTEM include search path
    
    Closes #1862
This page is out of date. Refresh to see the latest.
View
2  lib/cocoapods/generator/xcconfig/aggregate_xcconfig.rb
@@ -44,7 +44,7 @@ def save_as(path)
# @return [Xcodeproj::Config]
#
def generate
- header_search_path_flags = target.sandbox.public_headers.search_paths.map {|path| '-isystem'+path}
+ header_search_path_flags = target.sandbox.public_headers.search_paths.map {|path| '-isystem ' + path}
@xcconfig = Xcodeproj::Config.new({
'OTHER_LDFLAGS' => XCConfigHelper.default_ld_flags(target),
'HEADER_SEARCH_PATHS' => XCConfigHelper.quote(target.sandbox.public_headers.search_paths),
View
2  spec/unit/generator/xcconfig/aggregate_xcconfig_spec.rb
@@ -61,7 +61,7 @@ module XCConfig
end
it 'adds the sandbox public headers search paths to the xcconfig, with quotes, as system headers' do
- expected = "$(inherited) \"-isystem#{config.sandbox.public_headers.search_paths.join('" -isystem"')}\""
+ expected = "$(inherited) \"-isystem #{config.sandbox.public_headers.search_paths.join('" -isystem "')}\""
@xcconfig.to_hash['OTHER_CFLAGS'].should == expected
end
Something went wrong with that request. Please try again.