Dont allow pod names that begin with a `.` #2026

Merged
merged 13 commits into from Apr 15, 2014

Projects

None yet

3 participants

@dustywusty

No description provided.

@orta
Member
orta commented Apr 10, 2014

This is cool, sorry its taken a day or two to get around to, we get a lot of activity. Any chance you can add a test for this? It's probably just a matter of c&p-ing the spaces one.

Thanks for helping out!

@dustywusty

Np and absolutely!

clarkda added some commits Apr 10, 2014
clarkda Don't allow [!] A name for the Pod is required.
Usage:

    $ pod lib create NAME [TEMPLATE_URL]

      Creates a scaffold for the development of a new Pod according to the CocoaPods best practices.
      If a `TEMPLATE_URL`, pointing to a git repo containing a compatible template, is specified, it will be used in place of the default one.

Options:

    --silent    Show nothing
    --version   Show the version of CocoaPods
    --verbose   Show more debugging information
    --help      Show help banner of specified command to create a pod that begins with a period
61ea9fc
Dusty [Changelog] Disallow pod names that begin with `.`
Adding pull request for #2026
9617955
Dusty [Changelog] Disallow pod names that begin with `.` 4212cbe
clarkda Don't allow `pod lib create` to create a pod that begins with a period 7ae5b65
Dusty [Changelog] Disallow pod names that begin with `.`
Adding pull request for #2026
626dd8f
clarkda Merge branch 'master' of https://github.com/clarkda/CocoaPods deecbf9
@orta
Member
orta commented Apr 13, 2014

Amazing & perfect, if you give it a rebase and let me know you've done it I'll merge- tanks a bunch! :D

@dustywusty

I think i did that correctly? TIL rebase. 💥

@orta
Member
orta commented Apr 15, 2014

You might have done it right.
However it became unmergable in the 2 hours it took for me to get back to my computer 👯

@dustywusty

!! 💩

@orta
Member
orta commented Apr 15, 2014

move fast, break stuff 💃 . If you do it now I'll be around and monitoring, otherwise I'll go and pull it in myself manual.

@dustywusty

Let's kick it again! 💥

@orta
Member
orta commented Apr 15, 2014

none of those fails looks related to this, merging!

/cc @irrationalfab

@orta orta merged commit b5b8012 into CocoaPods:master Apr 15, 2014

1 check failed

Details continuous-integration/travis-ci The Travis CI build failed
@orta
Member
orta commented Apr 15, 2014

gif

@dustywusty

Appreciate all the help! ❤️

@fabiopelosin
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment