Remove intrusive, obnoxious "Cocoapods NEW_VERSION is available" message #448

Closed
wants to merge 1 commit into
from

Projects

None yet

7 participants

@qrush

I'm really sick of seeing this message appear in my builds. I'll update Cocoapods when it's ready. I don't need this library to have an attitude with me and when I choose to update it.

@travisbot

This pull request passes (merged e4c68ad into ab9b093).

@fabiopelosin
CocoaPods member

What about adding an option in the ~/.CocoaPods/CocoaPodsrc?

@subdigital

Agreed, that is pretty annoying.

@alloy
CocoaPods member

I agree this can be silenced, as long as we exit and warn early in case the spec repo version is incompatible. However, I do think we should print this in verbose mode, as that's meant to help debug issues. The message can be changed to just “A newer version of CocoaPods is available.”.

@qrush Can you update your patch to do that instead?

@cellularmitosis

just my two cents: I appear to be the only who appreciates seeing this message in my builds.

@fabiopelosin
CocoaPods member

just my two cents: I appear to be the only who appreciates seeing this message in my builds.

The rationale for it is that CocoaPods is rapidly evolving and often there are substantial enhancements/fixes that developers could miss if they are not aware of the update. I though that it was a feature that I would enjoy (as I'm the king of dev that update Xcode asap). Moreover, we had bug reports from people using ancient versions of CocoaPods that now are gone.

However, at the end is just a matter of taste. de gustibus non est disputandum but I would be curious to hear the percentage of how many users like it... Actually, if @alloy doesn't have any concern about it, I'll tweet a poll from http://polls.tw later tonight.

@alloy
CocoaPods member

I think the big difference lies in usage with RubyMotion or not. RubyMotion basically runs pod install every time you build your app, with Xcode, however, people generally only run it when they have added a new dependency or want to update dependencies.

In the first case I would also get tired of the message, in the latter case I would still get tired, but if it helps it helps and that’s more important atm.

To conclude, let’s always show it when run directly by the user (e.g. pod install) but let RubyMotion disable it (in the motion-cocoapods gem).

@alloy
CocoaPods member

@irrationalfab If you would still like to do the poll then please do, because knowing is half the battle, but let’s not make it configurable from the command-line. Too much options is what kills kittens.

@fabiopelosin
CocoaPods member

I think the big difference lies in usage with RubyMotion or not. RubyMotion basically runs pod install every time you build your app, with Xcode, however, people generally only run it when they have added a new dependency or want to update dependencies.

Ah I didn't though about ruby motion. Definitely annoying in that case.

To conclude, let’s always show it when run directly by the user (e.g. pod install) but let RubyMotion disable it (in the motion-cocoapods gem).

Seems the most sensible approach.

If you would still like to do the poll then please do, because knowing is half the battle, but let’s not make it configurable from the command-line.

Done! But quotes got messed up in the Tweet :-(.

Too much options is what kills kittens.

True 😿.

@fabiopelosin
CocoaPods member

The result of the poll:

  • 9.1% It is annoying (1 vote)
  • 90.9% It is useful (10 votes)

So we can add a flag to Pod::Config.

@alloy alloy referenced this pull request in HipByte/motion-cocoapods Sep 25, 2012
Closed

Do not warn user about available update of CP #34

@fabiopelosin fabiopelosin added a commit that referenced this pull request Oct 25, 2014
@fabiopelosin fabiopelosin [Config] Added update_notification attribute.
Closes #448
4b41448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment