Skip to content

[Project] Namespace subspecs in groups. #466

Merged
merged 1 commit into from Aug 21, 2012

4 participants

@fabiopelosin
CocoaPods member

Although it might be a bit slower I think that it is a great enhancement in usability. Moreover, it also makes easier to debug subspec related issues.

See #290.

img

@fabiopelosin
CocoaPods member

I've just tested it with a more complex project: it works and I didn't notice any significant slowdown.

@travisbot

This pull request passes (merged 647a397 into 7134b61).

@alloy
CocoaPods member
alloy commented Aug 21, 2012

So do you want to include this in the current release? Or did you create a pull-request because you want it in the RC?

@alloy
CocoaPods member
alloy commented Aug 21, 2012

It looks great btw.

@fabiopelosin
CocoaPods member

So do you want to include this in the current release? Or did you create a pull-request because you want it in the RC?

I think that it is better to include it in the next release, as it should not introduce bugs but with subspecs you never know, and I prefer to isolate big changes like the ones of the RC.

So if you agree we can merge it.

@alloy alloy merged commit e650527 into master Aug 21, 2012

1 check passed

Details default The Travis build passed
@alloy
CocoaPods member
alloy commented Aug 21, 2012

Agreed! ;)

@fabiopelosin fabiopelosin referenced this pull request Aug 21, 2012
Closed

Groups for subspecs #290

@alloy
CocoaPods member
alloy commented Sep 21, 2012
@alloy
CocoaPods member
alloy commented Sep 21, 2012

Hmm, I can’t reopen this ticket for some reason…

@fabiopelosin
CocoaPods member

Hmm, I can’t reopen this ticket for some reason…

Because the pull was merged and the branch was deleted. I'll check this one.

@fabiopelosin
CocoaPods member

And this time I'll add the specs!

@alloy
CocoaPods member
alloy commented Sep 21, 2012

Thanks :)

@coveralls

Coverage Status

Changes Unknown when pulling 647a397 on subspec_groups into ** on master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.