Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Switching subversion downloader from checkout to export #473

Merged
merged 1 commit into from Aug 24, 2012

Conversation

Projects
None yet
3 participants
Contributor

cellularmitosis commented Aug 23, 2012

This is for issue #245.

I don't know ruby, so I didn't understand the '%|checkout' syntax, so I instead just put "export" into the first quoted section.

Initially I had added a --force flag to the export operation, in order to work around the downloader already having created an empty dir with the same name, but I have not included the --force flag in this pull request because as mentioned in issue 245, the solution is to prevent the downloader from creating the empty dir. However, I don't know where in the codebase that happens, so I haven't included that change here. Note this means this checkin will break the svn downloader.

Also unaddressed is the issue of changing the bundle copy method to not include .svn directories.

This pull request fails (merged ac2b400 into 79089b4).

@alloy alloy merged commit ac2b400 into CocoaPods:master Aug 24, 2012

1 check failed

default The Travis build failed
Details
Owner

alloy commented Aug 24, 2012

Thanks for taking the time!

I fixed the syntax and the issue with the directory being created before the export in 402b875.

Btw, running the specs as described here should greatly help next time in guiding.

jzapater pushed a commit to jzapater/CocoaPods that referenced this pull request Sep 17, 2013

Merge pull request #473 from allenhuang/master
Update GHSidebarNav to 1.0.0

yalp pushed a commit to yalp/cocoapods-downloader that referenced this pull request Dec 12, 2013

Add :checkout option to allow checkinable pod when using --no-clean
The svn downloader uses export instead of checkout by default since
CocoaPods/CocoaPods#473.

But having a "checkin-able" pod is still usefull for the Pods developpers even
if it has been aggreed to be a minority-use case.
(from CocoaPods/CocoaPods#245 discussion).

@yalp yalp referenced this pull request in CocoaPods/cocoapods-downloader Dec 12, 2013

Merged

Add :checkout option to allow checkinable svn pod when combined with --no-clean #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment