Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SourcesManager] Fix wrong sudo recommendation 馃寛 #4735

Merged
merged 1 commit into from Jan 6, 2016

Conversation

mrcljx
Copy link
Contributor

@mrcljx mrcljx commented Jan 6, 2016

Issue
pod suggested to prefix gem install with sudo even though I'm using user-local rbenv.
sudo shouldn't be suggested if not needed to avoid chown pain later.

Solution
Extracted needs_sudo into own method needs_sudo?
Wrote a test for each outcome of needs_sudo?

P.S. Would be nice if you could add an empty Master section in CHANGELOG after releases to not make contributors guess what to do here without causing conflicts.

@neonichu
Copy link
Member

neonichu commented Jan 6, 2016

Thanks 馃嵒

neonichu added a commit that referenced this pull request Jan 6, 2016
[SourcesManager] Fix wrong sudo recommendation 馃寛
@neonichu neonichu merged commit 625c79b into CocoaPods:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants