[SourcesManager] Fix wrong sudo recommendation 馃寛 #4735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
pod
suggested to prefixgem install
withsudo
even though I'm using user-localrbenv
.sudo
shouldn't be suggested if not needed to avoidchown
pain later.Solution
Extracted
needs_sudo
into own methodneeds_sudo?
Wrote a test for each outcome of
needs_sudo?
P.S. Would be nice if you could add an empty Master section in CHANGELOG after releases to not make contributors guess what to do here without causing conflicts.