New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gh-issues-inspector to improve error reporting #5421

Merged
merged 2 commits into from Jul 9, 2016

Conversation

Projects
None yet
3 participants
@orta
Member

orta commented May 27, 2016

Fixes: #4817

Adds GitHub issue search to our exception handler, this is mainly to make it easier for people to find existing issues rather than writing new ones.

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta May 28, 2016

Member

Cool, I agreed with all feedback, it feels a lot better now

Member

orta commented May 28, 2016

Cool, I agreed with all feedback, it feels a lot better now

@@ -3,7 +3,7 @@
module Pod
describe Command::Install do
it 'tells the user that no Podfile or podspec was found in the project dir' do
exception = lambda { run_command('install', '--no-repo-update') }.should.raise Informative
exception = lambda { run_command('install') }.should.raise Informative

This comment has been minimized.

@orta

orta May 28, 2016

Member

that arg doesn't exist anymore /shrug

@orta

orta May 28, 2016

Member

that arg doesn't exist anymore /shrug

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Jun 20, 2016

Contributor

For reference, this requires some changes after the rename fastlane/fastlane@ac961b3

Contributor

KrauseFx commented Jun 20, 2016

For reference, this requires some changes after the rename fastlane/fastlane@ac961b3

@orta orta changed the title from [WIP] Use gh-issues-inspector to improve error reporting to Use gh-issues-inspector to improve error reporting Jun 26, 2016

@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins Jun 27, 2016

Member

@orta mind if I rebase this & get rubocop passing?

Member

segiddins commented Jun 27, 2016

@orta mind if I rebase this & get rubocop passing?

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jun 27, 2016

Member

Yep - sure! - it was taking a few hours to do CI each time so I couldn't seem to get it to pass too quickly

Member

orta commented Jun 27, 2016

Yep - sure! - it was taking a few hours to do CI each time so I couldn't seem to get it to pass too quickly

@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins Jun 27, 2016

Member

👍

Member

segiddins commented Jun 27, 2016

👍

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jun 30, 2016

Member

OK, I think that's everything rebased and triple-checked the rubocop

Member

orta commented Jun 30, 2016

OK, I think that's everything rebased and triple-checked the rubocop

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 4, 2016

Member

Anyone know why this is failing? Only occurred when rebasing

Member

orta commented Jul 4, 2016

Anyone know why this is failing? Only occurred when rebasing

Show outdated Hide outdated Gemfile.lock
@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 5, 2016

Member

Aye, good catch, amended the commit 👍

Member

orta commented Jul 5, 2016

Aye, good catch, amended the commit 👍

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 5, 2016

Member

Interesting, I've never heard of Inch, however - I have now added a lot of inline docs to satisfy it 👯

Member

orta commented Jul 5, 2016

Interesting, I've never heard of Inch, however - I have now added a lot of inline docs to satisfy it 👯

Show outdated Hide outdated CHANGELOG.md
@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 6, 2016

Member

Doh, re-refixed 💃

Member

orta commented Jul 6, 2016

Doh, re-refixed 💃

orta added some commits May 27, 2016

[GH Inspector] Initial work on integrating gh-issues-inspector
Update to use the latest GHInspector

Fix the API urls for the gh-inspector

@segiddins segiddins merged commit 5d2e68c into master Jul 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@segiddins segiddins deleted the orta-gh-inspector branch Jul 9, 2016

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 9, 2016

Member

MRW I run out of Reddit gold.

Member

orta commented Jul 9, 2016

MRW I run out of Reddit gold.

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Jul 9, 2016

Contributor

This is great 🚀

Contributor

KrauseFx commented Jul 9, 2016

This is great 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment