Update Version.rb to support Semantic Versioning pre-release versions #584

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@blakewatters

Modifies the regular expression used for validating versions and evaluating pre-releases to support pre-release version numbers conforming to the Semantic Versioning spec. Closes #583

Update Version class to support matching pre-release versions conform…
…ing to the Semantic Versioning specification. fixes #583
@fabiopelosin

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Oct 8, 2012

Member

It looks good, however I think that the underlying Gem::Version will not sort correctly (I haven't checked). So is 0.1-dev > 0.1.alpha.

Member

fabiopelosin commented Oct 8, 2012

It looks good, however I think that the underlying Gem::Version will not sort correctly (I haven't checked). So is 0.1-dev > 0.1.alpha.

@blakewatters

This comment has been minimized.

Show comment Hide comment
@blakewatters

blakewatters Oct 8, 2012

I wil throw some additional tests onto the patch comparing the sort order precedence with the SemVer spec -- there are a number of example test cases called out that will be easy to add.

I wil throw some additional tests onto the patch comparing the sort order precedence with the SemVer spec -- there are a number of example test cases called out that will be easy to add.

@fabiopelosin

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Dec 4, 2012

Member

@blakewatters If you are still interested in this pull please submit it to CocoaPods/Core. The Version class belongs to that gem, now.

Member

fabiopelosin commented Dec 4, 2012

@blakewatters If you are still interested in this pull please submit it to CocoaPods/Core. The Version class belongs to that gem, now.

@blakewatters

This comment has been minimized.

Show comment Hide comment
@blakewatters

blakewatters Dec 6, 2012

Well do, I find it irritating that I have to change my versioning scheme or live with mismatches between my tags and the Podspec

Well do, I find it irritating that I have to change my versioning scheme or live with mismatches between my tags and the Podspec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment