Ability to manually set DNS_BLOCK_ASSERTIONS=1 #803

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@xslim
Contributor

xslim commented Feb 19, 2013

Ability to add
-DNS_BLOCK_ASSERTIONS=1 to OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS with
set_dns_block_assertions_flag! to your Podfile.
Possibly closes #802

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 19, 2013

Member

Thanks for the taking the time, @xslim! However, this should really move to the defaults of Xcodeproj, as described on the mailing-list: https://groups.google.com/forum/?fromgroups=#!topic/cocoapods/x_gpp38W6gU.

I don’t think there’s a need to control it from the Podfile, though, they should just always be removed.

Member

alloy commented Feb 19, 2013

Thanks for the taking the time, @xslim! However, this should really move to the defaults of Xcodeproj, as described on the mailing-list: https://groups.google.com/forum/?fromgroups=#!topic/cocoapods/x_gpp38W6gU.

I don’t think there’s a need to control it from the Podfile, though, they should just always be removed.

@xslim

This comment has been minimized.

Show comment Hide comment
@xslim

xslim Feb 19, 2013

Contributor

@alloy Should I remove the flag and just add them as defaults ?

Contributor

xslim commented Feb 19, 2013

@alloy Should I remove the flag and just add them as defaults ?

@xslim

This comment has been minimized.

Show comment Hide comment
@xslim

This comment has been minimized.

Show comment Hide comment
@xslim

xslim Feb 19, 2013

Contributor

Ok, I made pull request for that one, CocoaPods/Xcodeproj#53
So maybe discard this

Contributor

xslim commented Feb 19, 2013

Ok, I made pull request for that one, CocoaPods/Xcodeproj#53
So maybe discard this

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 19, 2013

Member

Yes, let’s continue there.

Member

alloy commented Feb 19, 2013

Yes, let’s continue there.

@alloy alloy closed this Feb 19, 2013

jzapater pushed a commit to jzapater/CocoaPods that referenced this pull request Sep 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment