Proposed extension for issue #812 #814

Merged
merged 1 commit into from Feb 25, 2013

Conversation

Projects
None yet
2 participants
Contributor

punycode commented Feb 23, 2013

With the change in 0.16.3, which disabled flattening for zip files
some pods seem to break. While the rationale for the flattening
change is a good one, it would be nice to reenable flattening support
explicitly in the source configuration for your pod.

references #812

@punycode punycode Add explicit flattening option to Downloader:Http
With the change in 0.16.3, which disabled flattening for zip files
some pods seem to break. While the rationale for the flattening
change is a good one, it would be nice to reenable flattening support
explicitly in the source configuration for your pod.

references #812
6588e6a

punycode referenced this pull request in CocoaPods/Specs Feb 24, 2013

Closed

[Update] Google-Maps-iOS-SDK (1.1.0) #1314

Owner

alloy commented Feb 25, 2013

@punycode This looks good, thanks a lot!

The only thing I want changed before we can do a patch release is to go through the tests that actually call Downloader#download and minimize the number of different locations we download from. I.e. I think all the tests could use just one/two different locations, which should make running the full test suite faster.

If you have time to go through this, please let me know, otherwise I will have to do this tonight/tomorrow.

@alloy alloy merged commit 6588e6a into CocoaPods:master Feb 25, 2013

Owner

alloy commented Feb 25, 2013

I was wrong, it was fine as it is :)

Thanks a lot!

Owner

alloy commented Feb 25, 2013

Released as 0.16.4.

@jzapater jzapater pushed a commit to jzapater/CocoaPods that referenced this pull request Sep 17, 2013

@rsobik rsobik Merge pull request #814 from knickmack/MGBox2
Adding spec for MGBox2 2.0.0
163c54e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment