Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Podfile::DSL] Allow link_with targets to be passed as the arg list instead of an array #30

Merged
merged 1 commit into from Oct 11, 2013

Conversation

Projects
None yet
4 participants
Contributor

sharplet commented Oct 10, 2013

Seemed like it would be a nice API not to be required to wrap the target
list in an array explicitly. Hope you like it!

[Podfile::DSL] Allow link_with targets to be passed as the arg list i…
…nstead of an array

Also adds spec coverage to ensure backwards compatibility with the
array style.

Coverage Status

Coverage remained the same when pulling e3c93c6 on sharplet:link_with into 97632f1 on CocoaPods:master.

Coverage Status

Coverage decreased (-0.18%) when pulling e3c93c6 on sharplet:link_with into 97632f1 on CocoaPods:master.

Owner

fabiopelosin commented Oct 10, 2013

Looks good to me, can you add an entry to the CocoaPods/CocoaPods Changelog crediting yourself?

Contributor

sharplet commented Oct 10, 2013

Done.

Owner

fabiopelosin commented Oct 11, 2013

Awesome thanks!

fabiopelosin added a commit that referenced this pull request Oct 11, 2013

Merge pull request #30 from sharplet/link_with
[Podfile::DSL] Allow link_with targets to be passed as the arg list instead of an array

@fabiopelosin fabiopelosin merged commit 2f3fb92 into CocoaPods:master Oct 11, 2013

1 check passed

default The Travis CI build passed
Details

fabiopelosin added a commit to CocoaPods/CocoaPods that referenced this pull request Oct 11, 2013

Owner

orta commented Oct 11, 2013

Is the old syntax for this included in pod create XXlib ?

Owner

fabiopelosin commented Oct 11, 2013

No, we don't link with multiple targets there.

@sharplet sharplet deleted the sharplet:link_with branch Jan 24, 2014

Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015

Merge pull request #30 from sharplet/link_with
[Podfile::DSL] Allow link_with targets to be passed as the arg list instead of an array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment