Add CDN repo Source to allow retrieving specs from a web URL#469
Add CDN repo Source to allow retrieving specs from a web URL#469dnkoutso merged 1 commit intoCocoaPods:masterfrom
Conversation
|
I've made (hopefully) all the requested changes. |
|
I've added a threadpool to handle all the concurrency, using ruby-concurrent. In addition, I've moved all the optimizations that were previously in the analyzer, into the CDNSource file. |
amorde
left a comment
There was a problem hiding this comment.
This is awesome! Would love to see tests for this before merging
1200768 to
f6b0f23
Compare
|
So I've picked all the nits, and made most of the implementation-related methods private. I've begun adding unit tests. I'm using |
|
I've added the tests for |
|
I've pruned the new |
amorde
left a comment
There was a problem hiding this comment.
Haven't gotten the chance to try it out yet but the diff looks good to me
34c129c to
bd2b99e
Compare
|
I've made the changes requested by @segiddins. |
This PR complements #8280 in the main repo.
See all the details there.