New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDN repo Source to allow retrieving specs from a web URL #469
Conversation
I've made (hopefully) all the requested changes. |
I've added a threadpool to handle all the concurrency, using ruby-concurrent. In addition, I've moved all the optimizations that were previously in the analyzer, into the CDNSource file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Would love to see tests for this before merging
1200768
to
f6b0f23
Compare
So I've picked all the nits, and made most of the implementation-related methods private. I've begun adding unit tests. I'm using |
I've added the tests for |
I've pruned the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't gotten the chance to try it out yet but the diff looks good to me
34c129c
to
bd2b99e
Compare
I've made the changes requested by @segiddins. |
This PR complements #8280 in the main repo.
See all the details there.