Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Don't validate vendored_libraries path #55

Merged
merged 1 commit into from

3 participants

@keith
Collaborator

This removes the validation for vendored libraries to be identified with foo instead of libfoo.a. Since libfoo.a is the library's file path it makes sense to allow that directly. Invalid libraries will still be caught with https://github.com/CocoaPods/CocoaPods/blob/0dc6fa95b3636fa5923a401e2fea52e2f40c0e1e/lib/cocoapods/validator.rb#L293

@keith
Collaborator

This will fix all remaining lint failures on https://travis-ci.org/CocoaPods/Specs/builds/15783104#L205

@Kapin
Collaborator

Can you modify the changelog in the main project to specify this?

@Kapin Kapin merged commit 4bfdb88 into CocoaPods:master
@fabiopelosin

@Kapin There is no need to modify the changelog as this validation, if I'm correct, was introduced after the last release.

@keith
Collaborator

Yea I don't see anything in there about it on the master notes either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 20, 2013
  1. @keith
This page is out of date. Refresh to see the latest.
View
8 lib/cocoapods-core/specification/linter.rb
@@ -284,14 +284,6 @@ def _validate_libraries(libs)
end
end
- # Performs validations related to the `vendored_libraries` attribute.
- #
- def _validate_vendored_libraries(libs)
- if libraries_invalid?(libs)
- error "A vendored library should only be specified by its name"
- end
- end
-
# Performs validations related to the `license` attribute.
#
def _validate_license(l)
View
17 spec/specification/linter_spec.rb
@@ -310,23 +310,6 @@ def message_should_include(*values)
@spec.libraries = %w{libz libssl}
message_should_include('library', 'name')
end
-
- #------------------#
-
- it "checks that vendored libraries do not end with a .a extension" do
- @spec.vendored_libraries = %w{magic.a foo.a}
- message_should_include('library', 'name')
- end
-
- it "checks that vendored libraries do not end with a .dylib extension" do
- @spec.vendored_libraries = %w{magic.dylib foo.dylib}
- message_should_include('library', 'name')
- end
-
- it "checks that vendored libraries do not begin with lib" do
- @spec.vendored_libraries = %w{libfoo libbar}
- message_should_include('library', 'name')
- end
end
#--------------------------------------#
Something went wrong with that request. Please try again.