Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't validate vendored_libraries path #55

Merged
merged 1 commit into from Dec 20, 2013
Merged

Don't validate vendored_libraries path #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions lib/cocoapods-core/specification/linter.rb
View file
Open in desktop
Expand Up @@ -284,14 +284,6 @@ def _validate_libraries(libs)
end
end

# Performs validations related to the `vendored_libraries` attribute.
#
def _validate_vendored_libraries(libs)
if libraries_invalid?(libs)
error "A vendored library should only be specified by its name"
end
end

# Performs validations related to the `license` attribute.
#
def _validate_license(l)
Expand Down
17 changes: 0 additions & 17 deletions spec/specification/linter_spec.rb
View file
Open in desktop
Expand Up @@ -310,23 +310,6 @@ def message_should_include(*values)
@spec.libraries = %w{libz libssl}
message_should_include('library', 'name')
end

#------------------#

it "checks that vendored libraries do not end with a .a extension" do
@spec.vendored_libraries = %w{magic.a foo.a}
message_should_include('library', 'name')
end

it "checks that vendored libraries do not end with a .dylib extension" do
@spec.vendored_libraries = %w{magic.dylib foo.dylib}
message_should_include('library', 'name')
end

it "checks that vendored libraries do not begin with lib" do
@spec.vendored_libraries = %w{libfoo libbar}
message_should_include('library', 'name')
end
end

#--------------------------------------#
Expand Down