Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

FileSystemDataProvider::pods - ignore any entry that begins with a period #97

Merged
merged 4 commits into from Apr 7, 2014

Conversation

Projects
None yet
3 participants
Contributor

dustywusty commented Apr 4, 2014

Hi guys,

I've added SVN repo support in a plugin and one of the issues I have is linting the SVN spec repo. I think this will be a little cleaner than adding individual cases that deal with .svn, .hg, etc metadata.

Let me know what you think, thanks!

Owner

alloy commented Apr 5, 2014

Definitely cleaner. Can you add a few simple tests for .svn and .hg so we never regress on that and also add a CHANGELOG entry crediting yourself?

Owner

fabiopelosin commented Apr 5, 2014

Good call but we need also to add a check to the linter which prevents Pods names starting with the ..

Owner

fabiopelosin commented Apr 5, 2014

#98

Owner

fabiopelosin commented Apr 7, 2014

This can be merged as soon as the entry in the Changelog is added.

Contributor

dustywusty commented Apr 7, 2014

I'm going to update pod lib create to disallow . names as well -- if that sounds good to you guys?

Owner

fabiopelosin commented Apr 7, 2014

@clarkda... sounds really good... I would never have thought about pod lib create after merging this issue... good catch!

@fabiopelosin fabiopelosin merged commit eaf437d into CocoaPods:master Apr 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment