Subspecs cleanup #13
Merged
Subspecs cleanup #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keith we can probably address framework-only pods by directly copying any vendored frameworks over direct |
|
@segiddins awesome yea, I haven't gotten that far just yet but figured we should combine forces |
|
maybe @neonichu would be kind enough to give us push access? might make sense to start writing specs for this. |
|
@segiddins @keith sure, I'll add you |
|
❤️ |
|
|
|
@neonichu @segiddins anything I should update before merging this? |
| end | ||
| end | ||
| end | ||
|
|
||
| exit 1 |
|
Seems fine to me |
|
👍 |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers some of the same stuff as #11 but I've also extracted some of the constants that were used multiple times. There's still 1 issue with this that it doesn't work correctly with dependencies (like Fabric/Crashlytics) that are precompiled binaries.
On the subspecs front I believe we also need the
uniqI have in this script for specs that have a default subspec (my test has beenAPAddressBook)