Browse files

[Fix] Reverted LDFlags to properly load the Calabash libraries

  • Loading branch information...
1 parent 6aab266 commit 1f169df6044b3791f7968d872ce3f118072e5d6f @angelolloqui angelolloqui committed Mar 19, 2013
Showing with 1 addition and 1 deletion.
  1. +1 −1 Calabash/0.9.126/Calabash.podspec
View
2 Calabash/0.9.126/Calabash.podspec
@@ -19,6 +19,6 @@ this software.'
s.source = { :http => 'https://github.com/downloads/calabash/calabash-ios/calabash.framework-0.9.126.zip', :flatten => true }
s.preserve_paths = 'Headers', 'Versions', 'calabash'
s.source_files = 'Headers/*'
- s.xcconfig = { 'OTHER_LDFLAGS' => '-force_load "$(PODS_ROOT)/Calabash/calabash" -lstdc++' }
+ s.xcconfig = { 'OTHER_LDFLAGS' => '-force_load "$(PODS_ROOT)/Calabash/calabash.framework/calabash" -lstdc++' }
s.framework = 'CFNetwork'
end

11 comments on commit 1f169df

@angelolloqui

I am not sure why you have removed the calabash.framework/calabash before from the Spec but it does not load if you do not specify it. Please, do not remove it without testing that it actually works

@keith
CocoaPods member

Doesn't seem like either configuration works for me using 0.17.0.rc5

** BUILD SUCCEEDED **

 -> Calabash (0.9.126)
    - ERROR | [iOS] The `source_files` pattern did not match any file.

Analyzed 1 podspec.

Since 0.17 will be out soon you may want to try building it on there sometime gem install cocoapods --pre

@beatrupp

For me this commit breaks Calabash. I locally reverted it and then it works with Cocoapods 0.16.4 and 0.17.0.rc5

@keith
CocoaPods member

@beatrupp this is getting confusing which way does work for you?

@beatrupp

:-) I referred to the very commit we are talking about, so concerning line 22 above:

s.xcconfig = { 'OTHER_LDFLAGS' => '-force_load "$(PODS_ROOT)/Calabash/calabash.framework/calabash" -lstdc++' }  

breaks my builds and

s.xcconfig = { 'OTHER_LDFLAGS' => '-force_load "$(PODS_ROOT)/Calabash/calabash" -lstdc++' }  

works. HTH.

@keith
CocoaPods member

Gotcha that makes sense since I believe force_load is meant for loading frameworks, the extra path doesn't seem like it should be there. What's your experience @angelolloqui

@alloy
CocoaPods member

@Keithbsmiley Could it be that you’re seeing that lint error because there are no implementation source files, but only headers? s.source_files = 'Headers/*'

@keith
CocoaPods member

@alloy I'm actually not seeing a lint error of any kind, but it seems like it's working in different projects with different specs, which is strange

@alloy
CocoaPods member

@Keithbsmiley What about this one?

 -> Calabash (0.9.126)
    - ERROR | [iOS] The `source_files` pattern did not match any file.

Regarding the setting, the Calabash README states that what @angelolloqui did is correct:

Ensure that "Other linker flags" contains: -force_load "$(SRCROOT)/calabash.framework/calabash" -lstdc++

@keith
CocoaPods member

Interesting...

@angelolloqui

Well, I have tried both and none of them breaks my builds. However, when setting $(PODS_ROOT)/Calabash/calabash the Calabash framework is not loaded and none of the test works (the local server is not started). Only $(PODS_ROOT)/Calabash/calabash.framework/calabash works in my machine.

I am running pod 0.16.4 with XCode 4.6.1

Please sign in to comment.