Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

CocoaPods use american spelling.

  • Loading branch information...
commit f6506dc5b5f93cca2f82ff7172af9c522792ef9f 1 parent c58f6a3
@floere floere authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  SDWebImage/2.4/SDWebImage.podspec
View
2  SDWebImage/2.4/SDWebImage.podspec
@@ -2,7 +2,7 @@ Pod::Spec.new do |s|
s.name = 'SDWebImage'
s.version = '2.4'
s.platform = :ios
- s.licence = 'MIT'
+ s.license = 'MIT'
s.summary = 'UIImageView category adding suppport for remote images coming from the web asynchronously with caching.'
s.homepage = 'https://github.com/rs/SDWebImage'
s.author = { 'Olivier Poitrey' => 'rs@dailymotion.com' }

17 comments on commit f6506dc

@alloy
Owner

Jeez, me and my sleepy head. Thanks for catching this, Florian!

@floere
Owner

Sure. I'm thinking about a solution to this problem.

Here's the thing: The search engine crashed because of this. Now, there will be many more services built on top of this, not just the search engine. Sure, one could say: Just implement method missing for bla= methods etc (which is what I've done in the search). But instead of doing this in all services we should do it centrally.

So I propose a pre-push hook that quickly sanity checks the (modified) pod specs and lets one push only if it passes.

See any problems with this approach?

@lukeredpath

Hmm, this isn't an American spelling.

Licence, with a 'c', is a noun. License, with an 's', is the verb. The original was correct.

@floere
Owner

@lukeredpath It's the other way around. License is the american english noun and licence is the verb.

@alloy
Owner

Ah English-English or US-English… In general I personally tend to favor the original (you know, from England) over the US version, but I think that in this context most people will call it by its US name ‘license’.

http://en.wikipedia.org/wiki/License

@floere
Owner

Anyway, as an addendum to what I was saying: Not pre-push, pre-commit would be correct.

@lukeredpath

The commit note isn't clear; should it be using American spelling or not?

@alloy
Owner

@floere With regards to checking them, I was waiting for this to be implemented, but even then it might indeed be a good idea to run all specs through pod spec lint before push. Do git hooks propagate with clones?

@floere
Owner

You're right, I should have said: "CocoaPod specs use american spelling." Thanks for the feedback!

@floere
Owner

@alloy Let me look at it and get back to you.

@lukeredpath

Why not save people a step and simply alias :licence :license?

@alloy
Owner

Well, lint is only an extra measure. I think this specific problem will be solved by improving the spec template (pod spec create): CocoaPods/CocoaPods#71

@alloy
Owner

We can still alias indeed. But then we need to really ensure to be consistent with adding aliases where British and US English diverge.

@floere
Owner

@lukeredpath @alloy I'd advise against aliasing. It sure sounds tempting, but regarding other tools that will analyze pod specs, and the fact that this might be confusing to users it can be a problem. At least, I would not do it right now. I tried this in a gem of mine (James) and the questions on the right spelling came soon after. I suggest choosing a spelling and sticking with it.

@ConradIrwin

@alloy @floere I've added a hook to my repo so this won't happen again from me (https://gist.github.com/1370912), we could put it into the repository (with the executable bit set), but in order to activate it the user must still move it to the correct place manually.

@alloy
Owner

@ConradIrwin Oh that’s a smart one, great. We’ll create a symlink to the script when the user runs pod setup CocoaPods/CocoaPods#74

@floere
Owner

@Conradlrwin Also see #14 :)

Please sign in to comment.
Something went wrong with that request. Please try again.