Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

TestFlight SDK 1.0 #132

Merged
merged 5 commits into from

5 participants

@iprayforwaves

Please add TestFlightSDK 1.0 to podspecs repo. thanks!!

@travisbot

This pull request passes (merged f7b85b4 into e22047a).

@SevInf

Please, remove all comments

@SevInf

Thats wrong. Repo doesn't contain classes folder

@SevInf

You should link with libTestFlight here

@SevInf

@iprayforwaves, see CocoaPods/CocoaPods#98. There are few suggestions that might help

@travisbot

This pull request passes (merged 0ea113c into e22047a).

@siuying

tags '1.0.0' do not exists on your repo.

@siuying

Is it legal to redistribute TestFlight SDK?

It would be better if we could download the SDK via a URL and unzip it in CocoaPods.

@zwaldowski

That's a good question. I don't think it would be too much of an issue, since it's just the same thing. However, I've emailed them and I'll see what they say.

@iprayforwaves
@travisbot

This pull request passes (merged a8408a6 into e22047a).

TestFlightSDK/1.0.0/TestFlightSDK.podspec
@@ -0,0 +1,14 @@
+
+Pod::Spec.new do |s|
+ s.name = 'TestFlightSDK'
+ s.version = '1.0'
+ s.license = 'Commercial'
+ s.summary = 'TestFlightSDK for over-the-air beta testing and crash reporting.'
+ s.homepage = 'http://www.testflightapp.com'
+ s.author = { 'TestFlight' => 'support@testflightapp.com' }
+ s.source = { :git => 'https://github.com/danielctull/TestFlight-SDK.git', :tag => '1.0' }
+ s.description = 'TestFlightSDK for over-the-air beta testing and crash reporting.'
+ s.platform = :ios
+ s.source_files = '', '*.{h,m}'
@SevInf
SevInf added a note

Actually, only 'TestFlight.h' here will be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@iprayforwaves iprayforwaves change to source files section of podspec;
change version folder to match TestFlight version number;
f91fc75
@travisbot

This pull request passes (merged f91fc75 into e22047a).

TestFlightSDK/1.0.0/TestFlightSDK.podspec
@@ -0,0 +1,14 @@
+
+Pod::Spec.new do |s|
+ s.name = 'TestFlightSDK'
+ s.version = '1.0'
+ s.license = 'Commercial'
+ s.summary = 'TestFlightSDK for over-the-air beta testing and crash reporting.'
+ s.homepage = 'http://www.testflightapp.com'
+ s.author = { 'TestFlight' => 'support@testflightapp.com' }
+ s.source = { :git => 'https://github.com/danielctull/TestFlight-SDK.git', :tag => '1.0' }
+ s.description = 'TestFlightSDK for over-the-air beta testing and crash reporting.'
+ s.platform = :ios
+ s.source_files = '', '*.{h,m}'
+ s.library = 'libTestFlight'
@SevInf
SevInf added a note

This is still wrong.

  1. Don't add lib prefix when linking with libraries;
  2. TestFlight also requires libz; so result will be:
s.libraries = 'TestFlight', 'z'
  1. libTestFlight is not in libraries search path. It can be added with the following line:
s.xcconfig  =  { 'LIBRARY_SEARCH_PATHS' => "$(SRCROOT)/Pods/TestFlightSDK" }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@SevInf

@iprayforwaves, please don't submit podspec if you didn't check it on your machine.

TestFlightSDK/1.0/TestFlightSDK.podspec
@@ -0,0 +1,14 @@
+
+Pod::Spec.new do |s|
+ s.name = 'TestFlightSDK'
+ s.version = '1.0'
+ s.license = 'Commercial'
+ s.summary = 'TestFlightSDK for over-the-air beta testing and crash reporting.'
+ s.homepage = 'http://www.testflightapp.com'
+ s.author = { 'TestFlight' => 'support@testflightapp.com' }
+ s.source = { :git => 'https://github.com/danielctull/TestFlight-SDK.git', :tag => '1.0' }
+ s.description = 'TestFlightSDK for over-the-air beta testing and crash reporting.'
+ s.platform = :ios
+ s.source_files = '', 'TestFlight.h'
@SevInf
SevInf added a note

Remove empty string at the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@iprayforwaves

SevInf, I ran pod lint on spec file - something else I should do to check?

@travisbot

This pull request passes (merged 4b59afc into e22047a).

@SevInf

@iprayforwaves , as for 0.5.1 pod spec lint only checks that spec has all required attributes, it doesn't check that it actually works. To verify that you have correct spec you should actually try to add it to your project, check that you are able to import all required headers and project compiles and links successfully.

@SevInf SevInf merged commit a7e9291 into CocoaPods:master
@SevInf

Now its ok, merged.

@iprayforwaves

thanks! :) I finally figured out how to install locally to test. I'll try to get a few more done.

@hagmas hagmas referenced this pull request from a commit
@fabiopelosin fabiopelosin Merge branch 'master' into local-pod-source
* master:
  [#112] Refactoring based on suggestions by @alloy
  [#112] Improved remote url detection for spec repo
  [#132, #183] Fix to make repo update tolerant of stray files ~./cocoapods
  [#112] Introduced --push option for setup command
de6efbd
@hagmas hagmas referenced this pull request from a commit
@fabiopelosin fabiopelosin Merge branch 'master' into improved-search
* master:
  [#184] fix for documentation options
  [#180] check appledoc exit status
  [#112] Refactoring based on suggestions by @alloy
  [#112] Improved remote url detection for spec repo
  [#132, #183] Fix to make repo update tolerant of stray files ~./cocoapods
  [#112] Introduced --push option for setup command
9d87bf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 14 additions and 0 deletions.
  1. +14 −0 TestFlightSDK/1.0/TestFlightSDK.podspec
View
14 TestFlightSDK/1.0/TestFlightSDK.podspec
@@ -0,0 +1,14 @@
+Pod::Spec.new do |s|
+ s.name = 'TestFlightSDK'
+ s.version = '1.0'
+ s.license = 'Commercial'
+ s.summary = 'TestFlightSDK for over-the-air beta testing and crash reporting.'
+ s.homepage = 'http://www.testflightapp.com'
+ s.author = { 'TestFlight' => 'support@testflightapp.com' }
+ s.source = { :git => 'https://github.com/danielctull/TestFlight-SDK.git', :tag => '1.0' }
+ s.description = 'TestFlightSDK for over-the-air beta testing and crash reporting.'
+ s.platform = :ios
+ s.source_files = 'TestFlight.h'
+ s.library = 'TestFlight', 'z'
+ s.xcconfig = { 'LIBRARY_SEARCH_PATHS' => '$(SRCROOT)/Pods/TestFlightSDK' }
+end
Something went wrong with that request. Please try again.