BaseKit 0.2.5 #337

Merged
merged 2 commits into from Jul 24, 2012

Projects

None yet

3 participants

@brunow
brunow commented Jul 24, 2012

No description provided.

@travisbot

This pull request fails (merged 3694805 into e575743).

@fabiopelosin
Member

Can you make the podspec lint?

$ pod spec lint https://github.com/brunow/Specs/raw/36948052b889e09ae4feab330edc0fc955124775/BaseKit/0.2.5/BaseKit.podspec                                                                                                                [ruby-1.9.3-p194]

 -> BaseKit (0.2.5)
    - WARN  | clean_paths are deprecated and ignored (use preserve_paths)
    - NOTE  | XCODEBUILD >  ActionSheetPicker2/Pickers/DistancePickerView.m:97:70: warning: using 'stringWithString:' with a literal is redundant [-Wobjc-redundant-literal-use]
    - NOTE  | XCODEBUILD >  BaseKit/Code/FormMapping/BKFormMapper.m:300:56: warning: format specifies type 'int' but the argument has type 'double' [-Wformat]

[!] The spec did not pass validation.

For the compiler warnings, you can fix the library or add the compiler flags to the podspec:

s.compiler_flags = '-Wno-format'
@brunow
brunow commented Jul 24, 2012

Oh I didn't know that travis now compile objective c. I'll fix the library.
Thank you.

@fabiopelosin
Member

Oh I didn't know that travis now compile objective c. I'll fix the library.

It doesn't. Travis perform a lightweight lint (no compilation and no download of the library). The full lint that I reported was generated in my machine.

@travisbot

This pull request passes (merged 5455c05 into e575743).

@brunow
brunow commented Jul 24, 2012

I think it's good now, I've changed clean_paths with preserve_paths as said in the error message.

@brunow brunow merged commit 001d547 into CocoaPods:master Jul 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment