Added _.m, SubjectiveScript.m, and QUnit.m #365

Merged
merged 5 commits into from Aug 2, 2012

Projects

None yet

3 participants

@kmalakoff
Contributor

Let the fun begin!

@travisbot

This pull request fails (merged 02cf066 into 880a4b4).

Kevin Malakoff Added dependency 6e0bd4d
@travisbot

This pull request fails (merged 6e0bd4d into 880a4b4).

@fabiopelosin
Member

The error that you have been experiencing with Qunit is due to a wrong git url it is https://github.com/malakoff/QUnit.m.git instead of https://github.com/kmalakoff/QUnit.m.git (missing k in kmalakoff).

@fabiopelosin
Member

Same goes for the source of the other podspecs :-)

Kevin Malakoff Fixes typo 71cdefa
@kmalakoff
Contributor

Thank you for the quick reply!

I have updated my pull requests, but I'm still not able to run lint (in addition to the early dependency between _.m and SubjectiveScript.m)...new error:

OpenSourceProjects/Others/CocoaPodSpecs[master*]% pod spec lint Qunit.m/0.1.0/QUnit.m.podspec

/usr/local/rvm/gems/ruby-1.9.3-p194/gems/xcodeproj-0.3.1/lib/xcodeproj/project/object.rb:189: [BUG] Segmentation fault
ruby 1.8.7 (2011-12-28 patchlevel 357) [universal-darwin11.0]

[1]    92530 abort      pod spec lint Qunit.m/0.1.0/QUnit.m.podspec
@travisbot

This pull request fails (merged 71cdefa into 880a4b4).

@fabiopelosin
Member

Not sure why you are experiencing the errors. These are the results of the lint.

for QUnit.m s.framework = 'SenTestingKit' should do the trick.

$ pod spec lint QUnit.m/0.1.0/QUnit.m.podspec

 -> QUnit.m (0.1.0)
    - ERROR | XCODEBUILD >  QUnit.m/Lib/QUnitTests.h:31:9: fatal error: 'SenTestingKit/SenTestingKit.h' file not found

[!] The spec did not pass validation.

$ pod spec lint SubjectiveScript.m/0.1.0/SubjectiveScript.m.podspec

 -> SubjectiveScript.m (0.1.0)
    - WARN  | The summary should end with a dot

[!] The spec did not pass validation.

$ pod spec lint _.m/0.1.0/_.m.podspec

 -> _.m (0.1.0)

_.m.podspec passed validation.
Kevin Malakoff Fixes: #365 72d5fc8
@travisbot

This pull request passes (merged 72d5fc8 into 880a4b4).

@kmalakoff kmalakoff closed this Aug 2, 2012
@kmalakoff
Contributor

Wow! You're fast!

OK. I've done the two fixes, but still getting the seg-fault.

@kmalakoff kmalakoff reopened this Aug 2, 2012
@travisbot

This pull request passes (merged 72d5fc8 into 880a4b4).

@fabiopelosin
Member

One final and very tricky fix for QUnit.m (related to SenTestingKit):

  s.xcconfig = { 'FRAMEWORK_SEARCH_PATHS' => '"$(SDKROOT)/Developer/Library/Frameworks" "$(DEVELOPER_LIBRARY_DIR)/Frameworks"' }
@kmalakoff
Contributor

I wouldn't have figured that out ;-)

@travisbot

This pull request passes (merged 7f378e0 into 880a4b4).

@fabiopelosin
Member

Yeah, that was bad (CocoaPods/CocoaPods/435).

Btw, congratulations your podspecs are ready and I am merging them :-) Would you like push access?

@fabiopelosin fabiopelosin merged commit 511b555 into CocoaPods:master Aug 2, 2012

1 check passed

default The Travis build passed
Details
@kmalakoff
Contributor

Excellent! Thank you for guiding me through this!

Push access, eh? Is that just for me to get my podspecs updated quickly? If so sure, Of course, I still need to figure out why my linting crashes :-(

@fabiopelosin
Member

Excellent! Thank you for guiding me through this!

You're welcome 😃

Push access, eh? Is that just for me to get my podspecs updated quickly?

We tend to give push access once a contributor has shown good comprehension of how the podspecs work. It is for updating, fixing, and adding new pods. Naturally, if you feel unsure about something you can still create a pull request.

Btw, welcome aboard!

I still need to figure out why my linting crashes :-(

I've tested with ruby 1.8.7 and I'm not able to reproduce the issue. Not sure if it is strictly related to CocoaPods. Nonetheless you can try to install RVM and use ruby 1.9.3. It might solve your issues.

@kmalakoff
Contributor

Thank you for everything. Understood and I'll try my best.

I was able to fix the problem by doing a clean install of rvm and the latest ruby...got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment