Skip to content

Adds PSTCollectionView #551

Merged
merged 1 commit into from Sep 28, 2012

4 participants

@chakrit
chakrit commented Sep 28, 2012

From here: https://github.com/steipete/PSTCollectionView

There is a PSTCollectionView.podspec available in the repo but the author did not adds it to the pod spec repository.

Chakrit Wichian Adds PSTCollectionView
Using the PSTCollectionView.podspec available in the repo.
Somehow the author do not submits the spec to the specs repo
thus this PR from me.
a6c7084
@steipete

Thanks!

@steipete

"The Travis build failed" - should I merge this?

@chakrit
chakrit commented Sep 28, 2012

Frankly I'm not sure why the build failed :/ but I did ran pod spec lint and it says that everything is ok.

@fabiopelosin
CocoaPods member

I just linted it and it is fine. I'm merging it.

@chakrit let me know if you would you like push access?

@fabiopelosin fabiopelosin merged commit dd2d414 into CocoaPods:master Sep 28, 2012

1 check failed

Details default The Travis build failed
@chakrit
chakrit commented Sep 28, 2012

Awesome thanks :)

@irrationalfab Push access would be nice! but can't promise lots of work though I'll try to help when I can

@alloy
CocoaPods member
alloy commented Sep 29, 2012

@irrationalfab What’s our current policy on ‘0.0.1’ specs? I think the commit should be a fixed one instead of HEAD.

@fabiopelosin
CocoaPods member

Push access would be nice! but can't promise lots of work though I'll try to help when I can

@chakrit Granted.

What’s our current policy on ‘0.0.1’ specs? I think the commit should be a fixed one instead of HEAD.

@alloy Sorry, I missed it. @chakrit can you update the podspec?

@fabiopelosin fabiopelosin referenced this pull request in CocoaPods/CocoaPods Sep 29, 2012
Closed

Add check for head commit to the linter #563

@chakrit
chakrit commented Sep 29, 2012

@irrationalfab doing.

@chakrit chakrit pushed a commit that referenced this pull request Sep 29, 2012
Chakrit Wichian [PSTCollectionView] Specify exact commit sha instead of HEAD. #551 1be7eb8
@chakrit
chakrit commented Sep 29, 2012

Ah, didn't know you were using the [Update]/[Fix] commit message format. Will get it right next time.

@fabiopelosin
CocoaPods member

Thanks.

Ah, didn't know you were using the [Update]/[Fix] commit message format. Will get it right next time.

The message format is not that important :-). Anyway it is automatically generated if you use pod push.

@chakrit
chakrit commented Sep 29, 2012

Oh... so I should always use pod push on updates right? will keep that in mind.

@fabiopelosin
CocoaPods member

Oh... so I should always use pod push on updates right? will keep that in mind.

Only if it makes things easier for you. Push basically, lints, copies the podspec in the right folder (you don't use it from inside the repo), checks that the repo is clean, adds the commits for any podspec and pushes the repo to the remote.

@dchohfi dchohfi added a commit that referenced this pull request Oct 15, 2012
Chakrit Wichian [PSTCollectionView] Specify exact commit sha instead of HEAD. #551 a6fdfe7
@chakrit chakrit pushed a commit that referenced this pull request Jan 29, 2014
Chakrit Wichian [PSTCollectionView] Specify exact commit sha instead of HEAD. #551 f91bc7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.