PodSpec for Evernote Mac SDK #587

Merged
merged 4 commits into from Oct 9, 2012

Conversation

Projects
None yet
3 participants

PodSpec for Evernote Mac SDK, currently not working, please fix.

Initial Commit
PodSpec for Evernote Mac SDK
Owner

orta commented Oct 7, 2012

This pod doesn't have a commit / tag reference in s.source

The Evernote SDK for Mac, didn't have any tags. The source paths don't seem to be correct either. I was hoping someone who has made a few of these could correct it.

Thanks
Dean

On Oct 7, 2012, at 8:21 PM, Orta notifications@github.com wrote:

This pod doesn't have a commit / tag reference in s.source


Reply to this email directly or view it on GitHub.

Owner

orta commented Oct 7, 2012


Pod::Spec.new do |s|
  s.name     = 'Evernote-SDK-Mac'
  s.version  = '1.22'
  s.platform = :osx
  s.license  = 'https://github.com/evernote/evernote-sdk-mac/blob/master/LICENSE'
  s.summary  = 'Evernote SDK for osx.'
  s.homepage = 'https://github.com/evernote/evernote-sdk-mac'
  s.author   = 'Evernote'
  s.source   = { :git => 'https://github.com/evernote/evernote-sdk-mac.git', :commit => "2dc7d3dae864c93952ebc008f987fb219e27883f" }
  s.source_files = 'src/edam/*.{h,m}', 'src/thrift/*.{h,m}', 'src/thrift/protocol/*.{h,m}', 'src/thrift/transport/*.{h,m}'
end

This looks good to me.

Thank you very much. I updated the source and pushed it back. What do I do next?

On Oct 8, 2012, at 12:11 AM, Orta notifications@github.com wrote:

Pod::Spec.new do |s|
s.name = 'Evernote-SDK-Mac'
s.version = '1.22'
s.platform = :osx
s.license = 'https://github.com/evernote/evernote-sdk-mac/blob/master/LICENSE'
s.summary = 'Evernote SDK for osx.'
s.homepage = 'https://github.com/evernote/evernote-sdk-mac'
s.author = 'Evernote'
s.source = { :git => 'https://github.com/evernote/evernote-sdk-mac.git', :commit => "2dc7d3dae864c93952ebc008f987fb219e27883f" }
s.source_files = 'src/edam/.{h,m}', 'src/thrift/.{h,m}', 'src/thrift/protocol/.{h,m}', 'src/thrift/transport/.{h,m}'
end

Owner

orta commented Oct 8, 2012

We're close to it now, the pod's file name needs to be Evernote-SDK-Mac.podspec instead of Evernote-sdk-mac.podspec as that's how the capitalization is done everywhere else, but I think that should be the last thing, if you do that I'll merge it into the repository and you've contributed!

Owner

fabiopelosin commented Oct 8, 2012

Also:

  s.license  = 'Custom permissive license'

CocoaPods is able to automatically detect LICENSE files in the root of the library, so you only need to specify the type. In this case I wasn't able to find a name for the license, but if you do please update my snippet.


The source files can be simplified to:

s.source_files = 'src/**/*.{h,m}'

Finally you need to update the version in the path of the podspec Evernote-SDK-Mac/1.22/Evernote-sdk-mac.podspec.

ok I made the changes, whats next?

On Oct 8, 2012, at 2:47 PM, Fabio Pelosin notifications@github.com wrote:

Also:

s.license = 'Custom permissive license'
CocoaPods is able to automatically detect LICENSE files in the root of the library, so you only need to specify the type. In this case I wasn't able to find a name for the license, but if you do please update my snippet.

The source files can be simplified to:

s.source_files = 'src/*/.{h,m}'
Finally you need to update the version in the path of the podspec Evernote-SDK-Mac/1.22/Evernote-sdk-mac.podspec.


Reply to this email directly or view it on GitHub.

Owner

orta commented Oct 8, 2012

I'm leaving the merging for @irrationalfab

111
112 -> Evernote-SDK-Mac (1.22)
113    - WARN  | Git sources without tag should be marked as 0.0.1 (not always applicable)

The reason it failed linting is that you're version is correct, but we're not using semantic tags because they don't support it. Your commit is correct though :)

Anything else I need to do?
Can I some how run this local so I can start my project I want to build with this pod?

Thanks
Dean

On Oct 8, 2012, at 9:44 PM, Orta notifications@github.com wrote:

I'm leaving the merging for @irrationalfab

111
112 -> Evernote-SDK-Mac (1.22)
113 - WARN | Git sources without tag should be marked as 0.0.1 (not always applicable)
``

The reason it failed linting is that you're version is correct, but we're not using semantic tags because they don't support it. Your commit is correct though :)

Reply to this email directly or view it on GitHub.

Owner

orta commented Oct 9, 2012

Yes, just add this to your podfile

Just change Pod::Spec.new to pod

pod  do |s|
  s.name     = 'Evernote-SDK-Mac'
  s.version  = '1.22'
  s.platform = :osx
  s.license  = 'https://github.com/evernote/evernote-sdk-mac/blob/master/LICENSE'
  s.summary  = 'Evernote SDK for osx.'
  s.homepage = 'https://github.com/evernote/evernote-sdk-mac'
  s.author   = 'Evernote'
  s.source   = { :git => 'https://github.com/evernote/evernote-sdk-mac.git', :commit => "2dc7d3dae864c93952ebc008f987fb219e27883f" }
  s.source_files = 'src/edam/*.{h,m}', 'src/thrift/*.{h,m}', 'src/thrift/protocol/*.{h,m}', 'src/thrift/transport/*.{h,m}'
end

fabiopelosin added a commit that referenced this pull request Oct 9, 2012

Merge pull request #587 from dmkrueger/master
PodSpec for Evernote Mac SDK

@fabiopelosin fabiopelosin merged commit 55c15ba into CocoaPods:master Oct 9, 2012

1 check failed

default The Travis build failed
Details
Owner

fabiopelosin commented Oct 9, 2012

I'm leaving the merging for @irrationalfab

FYI, I'm experimenting with validations that are applicable in the 99% of the cases. For now we just add them and the build fails, but it will magically heal on the next push because we only fail on errors for the Pods that received a commit. I'm toying around with the idea to add a magic comment to the podspecs to relax the linter in particular cases like this one.

fabiopelosin added a commit that referenced this pull request Jan 29, 2014

Merge pull request #587 from dmkrueger/master
PodSpec for Evernote Mac SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment