New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version 0.5 of MBProgressHUD. Thanks for this awesome project! #78

Merged
merged 2 commits into from Mar 23, 2012

Conversation

Projects
None yet
4 participants
@luosky
Contributor

luosky commented Mar 23, 2012

No description provided.

@SevInf

This comment has been minimized.

Show comment
Hide comment
@SevInf

SevInf Mar 23, 2012

Add also MBProgressHUD.xcodeproj and MBProgressHUD.xcworkspace to clean_paths

SevInf commented on MBProgressHUD/0.5/MBProgressHUD.podspec in 01de7cb Mar 23, 2012

Add also MBProgressHUD.xcodeproj and MBProgressHUD.xcworkspace to clean_paths

@SevInf

This comment has been minimized.

Show comment
Hide comment
@SevInf

SevInf Mar 23, 2012

Contributor

After you'll do this changes, you can go ahead and merge this pull request. I've given you push access

Contributor

SevInf commented Mar 23, 2012

After you'll do this changes, you can go ahead and merge this pull request. I've given you push access

luosky added a commit that referenced this pull request Mar 23, 2012

Merge pull request #78 from luosky/master
Added version 0.5 of MBProgressHUD

@luosky luosky merged commit 6416a83 into CocoaPods:master Mar 23, 2012

@alloy

This comment has been minimized.

Show comment
Hide comment
@alloy

alloy Mar 23, 2012

Member

@luosky The source used in this spec is that of a fork of https://github.com/jdg/MBProgressHUD, which has the changes of the fork merged in, so I’d rather point to the original. Likewise, I think the original author is missing from the list of authors. Can you update those things?

Member

alloy commented Mar 23, 2012

@luosky The source used in this spec is that of a fork of https://github.com/jdg/MBProgressHUD, which has the changes of the fork merged in, so I’d rather point to the original. Likewise, I think the original author is missing from the list of authors. Can you update those things?

@luosky

This comment has been minimized.

Show comment
Hide comment
@luosky

luosky Mar 23, 2012

Contributor

@alloy This spec is based on your previous 0.41 commit. I see that you use the fork from Matej on the spec of version 0.41, and he is contributing most of the recent commits. But he only tagged 0.5 on jdg's branch. So I have to changed to jdg's source.

I will add jdg to the author list. Thanks for your comment.

Contributor

luosky commented Mar 23, 2012

@alloy This spec is based on your previous 0.41 commit. I see that you use the fork from Matej on the spec of version 0.41, and he is contributing most of the recent commits. But he only tagged 0.5 on jdg's branch. So I have to changed to jdg's source.

I will add jdg to the author list. Thanks for your comment.

@alloy

This comment has been minimized.

Show comment
Hide comment
@alloy

alloy Mar 23, 2012

Member

@luosky Cool thanks! I don’t remember the specifics of the previous version, maybe his commits weren’t merged by then or so, but I should have included jdg as an author, my bad :)

Member

alloy commented Mar 23, 2012

@luosky Cool thanks! I don’t remember the specifics of the previous version, maybe his commits weren’t merged by then or so, but I should have included jdg as an author, my bad :)

@luosky

This comment has been minimized.

Show comment
Hide comment
@luosky

luosky Mar 23, 2012

Contributor

@SevInf @alloy Modification has been done. Thank you all :)

Contributor

luosky commented Mar 23, 2012

@SevInf @alloy Modification has been done. Thank you all :)

@dev4dev

This comment has been minimized.

Show comment
Hide comment
@dev4dev

dev4dev Dec 25, 2012

There is some issue, I get not latest source code after pod install

platform :ios, '5.0'

pod 'MBProgressHUD', '~> 0.5'

I don't know which version it was, but I had to update it manually to latest from GH repo.

dev4dev commented Dec 25, 2012

There is some issue, I get not latest source code after pod install

platform :ios, '5.0'

pod 'MBProgressHUD', '~> 0.5'

I don't know which version it was, but I had to update it manually to latest from GH repo.

@luosky

This comment has been minimized.

Show comment
Hide comment
@luosky

luosky Jan 26, 2013

Contributor

@dev4dev The lastest tag in MBProgressHUD is 0.5 which is made 10 month ago. So maybe you can ask the author of MBProgressHUD to make a lastest tag or you can specify which commit you want to use in your Podfile.

Contributor

luosky commented Jan 26, 2013

@dev4dev The lastest tag in MBProgressHUD is 0.5 which is made 10 month ago. So maybe you can ask the author of MBProgressHUD to make a lastest tag or you can specify which commit you want to use in your Podfile.

luosky added a commit that referenced this pull request Jan 29, 2014

Merge pull request #78 from luosky/master
Added version 0.5 of MBProgressHUD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment