Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix MagicalRecord 1.8.3 installation issues #898

Merged
merged 3 commits into from

2 participants

@dflems

As of right now, the 1.8.3 tag of MagicalRecord doesn't install correctly. The podspec in CocoaPods/Specs differs from the one in the MagicalRecord repo in that it doesn't wrap the include call in Pods-prefix.pch with an #ifdef __OBJC__ ... #endif. This causes a number of compilation errors, currently being experienced (magicalpanda/MagicalRecord#146) by MagicalRecord users such as myself. 1.8.3 is an older version, but it is the last version to support iOS 4 out-of-the-box.

On a side note, I made a pull request a few months ago and never got push access to the CocoaPods repo. Could I get access to that?

Edit: Whoops. Sorry for the extra commits. It wound up not passing validation due to some small semantic issues in the podspec I copied over (use https and end the description with a period). Is there a way to run those validations client-side so Travis won't yell at me next time?

@orta
Owner

So, I've added you to the team for commit access, and everything seems to look ok from my side. Thanks @dflems!

Merging [+..••]

@orta orta merged commit f83dcea into CocoaPods:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 7 additions and 1 deletion.
  1. +7 −1 MagicalRecord/1.8.3/MagicalRecord.podspec
View
8 MagicalRecord/1.8.3/MagicalRecord.podspec
@@ -10,5 +10,11 @@ Pod::Spec.new do |s|
s.source_files = 'Source/**/*.{h,m}'
s.framework = 'CoreData'
- s.prefix_header_contents = "#define MR_SHORTHAND 1\n#import \"CoreData+MagicalRecord.h\""
+ def s.post_install(target)
+ prefix_header = config.project_pods_root + target.prefix_header_filename
+ prefix_header.open('a') do |file|
+ file.puts(%{#ifdef __OBJC__\n#define MR_SHORTHAND 1\n#import "CoreData+MagicalRecord.h"\n#endif})
+ end
+ end
end
+
Something went wrong with that request. Please try again.