Update for ReactiveCocoa 0.13.1 with iOS 6 support #954

Merged
merged 1 commit into from Dec 31, 2012

Conversation

Projects
None yet
3 participants

pyrtsa commented Dec 31, 2012

ReactiveCocoa currently still targets iOS 5, which means the ARC
support for GCD objects needs to be turned off when targeting iOS 6.
Hence, #defining OS_OBJECT_USE_OBJC as 0. This fix shouldn't affect any
other project files using either GCD or ARC in any way. For more info,
see: https://github.com/github/ReactiveCocoa/issues/204

@pyrtsa pyrtsa Update for ReactiveCocoa 0.13.1 with iOS 6 support
ReactiveCocoa currently still targets iOS 5, which means the ARC
support for GCD objects needs to be turned off when targeting iOS 6.
Hence, #defining OS_OBJECT_USE_OBJC as 0. This fix shouldn't affect any
other project files using either GCD or ARC in any way. For more info,
see: https://github.com/github/ReactiveCocoa/issues/204
cd5eadd

pyrtsa referenced this pull request in ReactiveCocoa/ReactiveCocoa Dec 31, 2012

Closed

dispatch_release unavailable on ARC? #204

Owner

orta commented Dec 31, 2012

Hey @pyrtsa thanks for this!
Is s.compiler_flags = '-DOS_OBJECT_USE_OBJC=0' something we're going to want in the older versions of ReactiveCocoa?

@orta orta added a commit that referenced this pull request Dec 31, 2012

@orta orta Merge pull request #954 from pyrtsa/master
Update for ReactiveCocoa 0.13.1 with iOS 6 support
5c89a7d

@orta orta merged commit 5c89a7d into CocoaPods:master Dec 31, 2012

1 check failed

default The Travis build failed
Details

pyrtsa commented Dec 31, 2012

Is s.compiler_flags = '-DOS_OBJECT_USE_OBJC=0' something we're going to want in the older versions of ReactiveCocoa?

Yes it is.

Owner

orta commented Dec 31, 2012

Added: 905cd85

Owner

alloy commented Jan 29, 2013

@pyrtsa I have a fix for CP itself here. I’ll try to merge it and release it tomorrow. Although, if you’re able with Bundler, and would like to try it, that would be much appreciated.

@orta orta added a commit that referenced this pull request Jan 29, 2014

@orta orta Merge pull request #954 from pyrtsa/master
Update for ReactiveCocoa 0.13.1 with iOS 6 support
6c4e56d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment