[NativeTarget] #add_source_file -> #add_source_files. #16

Merged
merged 4 commits into from Jun 25, 2012

Conversation

Projects
None yet
2 participants

@fabiopelosin fabiopelosin referenced this pull request in CocoaPods/CocoaPods Jun 21, 2012

Closed

Pull Generating support files phase is slow #349

+ copy_header_phase = source_file_description[:copy_header_phase]
+ compiler_flags = source_file_description[:compiler_flags]
+
+ file = files.find { |file| file.path == path.to_s } || @project.files.new('path' => path.to_s)

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Jun 22, 2012

Owner

You should probably also check the file_references list before creating a new PBXFileReference. E.g.:

file = (files + file_references).find { |file| file.path == path.to_s } || @project.files.new('path' => path.to_s)

Btw, can we rename file_references to new_files?

@alloy

alloy Jun 22, 2012

Owner

You should probably also check the file_references list before creating a new PBXFileReference. E.g.:

file = (files + file_references).find { |file| file.path == path.to_s } || @project.files.new('path' => path.to_s)

Btw, can we rename file_references to new_files?

@fabiopelosin

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Jun 25, 2012

Owner

I've implemented your suggestions and I'm merging.

Owner

fabiopelosin commented Jun 25, 2012

I've implemented your suggestions and I'm merging.

fabiopelosin added a commit that referenced this pull request Jun 25, 2012

Merge pull request #16 from CocoaPods/CP-ticket-291
[NativeTarget] #add_source_file -> #add_source_files.

@fabiopelosin fabiopelosin merged commit f0d455b into develop Jun 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment