Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Configuration] Don't overwrite warnings defaults. #19

Merged
merged 1 commit into from Jul 3, 2012

Conversation

Projects
None yet
2 participants
Owner

fabiopelosin commented Jun 27, 2012

@alloy What was the reason to override the defaults?

Owner

fabiopelosin commented Jul 2, 2012

@alloy Continuing the discussion here because the other pull was pointing to master.

In my opinion, we should specify just the keys required for the project to compile and nothing else so we can fall back in the Xcode defaults. For example I think that we should remove also GCC_VERSION, GCC_ENABLE_OBJC_EXCEPTIONS, INSTALL_PATH, GCC_C_LANGUAGE_STANDARD and some others.

fabiopelosin added a commit that referenced this pull request Jul 3, 2012

Merge pull request #19 from CocoaPods/warnings
[Configuration] Don't overwrite warnings defaults.

@fabiopelosin fabiopelosin merged commit c41f423 into develop Jul 3, 2012

Owner

fabiopelosin commented Jul 3, 2012

@alloy I've merged this because it looks that it doesn't create any side effects.

Owner

alloy commented Jul 4, 2012

You’re completely right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment