Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .H to HEADER_FILES_EXTENSIONS #239

Merged
merged 5 commits into from Feb 19, 2015

Conversation

Projects
None yet
2 participants
@banjun
Copy link
Contributor

commented Feb 10, 2015

We have legacy header files named capitalized like FOO.H.
Currently pod install adds these headers to the Compile Sources build phase.
This PR handles FOO.H as a header file and does not add to the Compile Sources, same as manually drag & drop them to Xcode project. (.H files are treated as C Header in a project by default)

@segiddins

This comment has been minimized.

Copy link
Member

commented Feb 10, 2015

It would probably be better to make extension comparisons case insensitive

@banjun

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2015

I think it's more aggressive and reasonable.

@@ -412,7 +412,7 @@ def add_file_references(file_references, compiler_flags = {})

extension = File.extname(file.path)

This comment has been minimized.

Copy link
@segiddins

segiddins Feb 19, 2015

Member

I'd prefer the downcase to be here, but no big deal.

@segiddins

This comment has been minimized.

Copy link
Member

commented Feb 19, 2015

Can we have a CHANGELOG entry and some test coverage?

@banjun

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2015

added a test and updated CHANGELOG.

@segiddins

This comment has been minimized.

Copy link
Member

commented Feb 19, 2015

Excellent, thanks @banjun!

segiddins added a commit that referenced this pull request Feb 19, 2015

Merge pull request #239 from banjun/support-.H-as-headers
add .H to HEADER_FILES_EXTENSIONS

@segiddins segiddins merged commit 52b8878 into CocoaPods:master Feb 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@banjun

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2015

thank you for review!

@banjun banjun deleted the banjun:support-.H-as-headers branch Feb 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.