Support comments attribute in all build phases, groups and targets. #51

Merged
merged 2 commits into from Feb 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

drodriguez commented Feb 8, 2013

Xcode 2 and 3 used to have a comments attribute almost everywhere. I have
found instances of comments in:

  • PBXShellScriptBuildPhase
  • PBXCopyFilesBuildPhase
  • PBXNativeTarget
  • PBXApplicationTarget
  • PBXLibraryTarget
  • PBXAggregateTarget
  • PBXGroup

Seems that Xcode 4 doesn't remove those comments, so supporting them is nice for people with old projects being converted to CocoaPods.

A search in Google for "filetype:pbxproj comments" gives you some of this results.

Fixes CocoaPods/CocoaPods#696

drodriguez added some commits Feb 8, 2013

@drodriguez drodriguez Support comments attribute in all build phases, groups and targets.
Xcode 2 and 3 used to have a comments attribute almost everywhere. I have
found instances of comments in:
- PBXShellScriptBuildPhase
- PBXCopyFilesBuildPhase
- PBXNativeTarget
- PBXApplicationTarget
- PBXLibraryTarget
- PBXAggregateTarget
- PBXGroup
eb85980
@drodriguez drodriguez Fix typo and bad test.
I should actually write and *build* the test before commiting.
2025710
Owner

fabiopelosin commented Feb 9, 2013

Looks reasonable. Would you like push access to directly commit patches you feel confident about?

@fabiopelosin fabiopelosin added a commit that referenced this pull request Feb 9, 2013

@fabiopelosin fabiopelosin Merge pull request #51 from drodriguez/legacy-xcode3-attributes
Support comments attribute in all build phases, groups and targets.
750e41a

@fabiopelosin fabiopelosin merged commit 750e41a into CocoaPods:master Feb 9, 2013

1 check passed

default The Travis build passed
Details
Contributor

drodriguez commented Feb 9, 2013

Thanks Fabio, already have push access. The confidence is what’s I’m not sure about :D

drodriguez deleted the drodriguez:legacy-xcode3-attributes branch Feb 9, 2013

Owner

fabiopelosin commented Feb 9, 2013

Thanks Fabio, already have push access.

Oh, yes... I thought I've checked.

The confidence is what’s I’m not sure about :D

Yes if in doubt opening a pull is much better. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment