Added DNS_BLOCK_ASSERTIONS=1 to default Xcode release flags #53

Merged
merged 2 commits into from Feb 19, 2013

Conversation

Projects
None yet
4 participants
@xslim
Contributor

xslim commented Feb 19, 2013

No description provided.

@xslim xslim referenced this pull request in CocoaPods/CocoaPods Feb 19, 2013

Closed

Ability to manually set DNS_BLOCK_ASSERTIONS=1 #803

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 19, 2013

Member

Can you add a simple test for it? This way we ensure that in the future we don’t accidentally remove it (during a refactor etc).

Member

alloy commented Feb 19, 2013

Can you add a simple test for it? This way we ensure that in the future we don’t accidentally remove it (during a refactor etc).

@xslim

This comment has been minimized.

Show comment Hide comment
@xslim

xslim Feb 19, 2013

Contributor

I have some problems with implementing testing. As I understood this is not a pure RSpec…

How should I test here thing like

build_settings['OTHER_CFLAGS'].should  include('-DNS_BLOCK_ASSERTIONS=1')

?

Contributor

xslim commented Feb 19, 2013

I have some problems with implementing testing. As I understood this is not a pure RSpec…

How should I test here thing like

build_settings['OTHER_CFLAGS'].should  include('-DNS_BLOCK_ASSERTIONS=1')

?

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 19, 2013

Member

Indeed. With Bacon the matcher methods are on the ‘should’ object. So in this case:

build_settings['OTHER_CFLAGS'].should.include('-DNS_BLOCK_ASSERTIONS=1')
Member

alloy commented Feb 19, 2013

Indeed. With Bacon the matcher methods are on the ‘should’ object. So in this case:

build_settings['OTHER_CFLAGS'].should.include('-DNS_BLOCK_ASSERTIONS=1')
@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 19, 2013

Member

And to check that an object is not included:

build_settings['OTHER_CFLAGS'].should.not.include('-DNS_BLOCK_ASSERTIONS=1')
Member

alloy commented Feb 19, 2013

And to check that an object is not included:

build_settings['OTHER_CFLAGS'].should.not.include('-DNS_BLOCK_ASSERTIONS=1')
@xslim

This comment has been minimized.

Show comment Hide comment
@xslim

xslim Feb 19, 2013

Contributor

oh, but how do I run the tests properly?
rspec --tag focus spec/project_spec.rb seems not working

Contributor

xslim commented Feb 19, 2013

oh, but how do I run the tests properly?
rspec --tag focus spec/project_spec.rb seems not working

@xslim

This comment has been minimized.

Show comment Hide comment
@xslim

xslim Feb 19, 2013

Contributor

ok, got it bacon spec/project_spec.rb

So I pushed tests..

Contributor

xslim commented Feb 19, 2013

ok, got it bacon spec/project_spec.rb

So I pushed tests..

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 19, 2013

Member

Awesome, thanks!

I will merge this later today (I have to check if we should run this test for :osx as well) and do a release.

Member

alloy commented Feb 19, 2013

Awesome, thanks!

I will merge this later today (I have to check if we should run this test for :osx as well) and do a release.

@alloy alloy merged commit c9e563d into CocoaPods:master Feb 19, 2013

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 19, 2013

Member

@irrationalfab Are the other commits you’ve added since 0.4.3 ready for release?

Member

alloy commented Feb 19, 2013

@irrationalfab Are the other commits you’ve added since 0.4.3 ready for release?

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 19, 2013

Member

I’ll release a new gem tomorrow.

Member

alloy commented Feb 19, 2013

I’ll release a new gem tomorrow.

@fabiopelosin

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Feb 19, 2013

Member

@alloy I've added a some minor stuff which includes minor changes in the API, so I think that we should release 0.5. If you release 0.5 please remove these lines.

Member

fabiopelosin commented Feb 19, 2013

@alloy I've added a some minor stuff which includes minor changes in the API, so I think that we should release 0.5. If you release 0.5 please remove these lines.

@alloy alloy referenced this pull request in CocoaPods/CocoaPods Feb 20, 2013

Closed

NS_BLOCK_ASSERTIONS=1 by default for Pod porject #802

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 20, 2013

Member

Released.

Member

alloy commented Feb 20, 2013

Released.

@tsafrir

This comment has been minimized.

Show comment Hide comment
@tsafrir

tsafrir Feb 23, 2013

@xslim When a .Podspec (like 'zipzap') defines value for OTHER_CPLUSPLUSFLAGS it will be ignored.
Should there be $(inherited) before NS_BLOCK_ASSERTIONS=1 ?
(The same probably goes for OTHER_CFLAGS)

tsafrir commented Feb 23, 2013

@xslim When a .Podspec (like 'zipzap') defines value for OTHER_CPLUSPLUSFLAGS it will be ignored.
Should there be $(inherited) before NS_BLOCK_ASSERTIONS=1 ?
(The same probably goes for OTHER_CFLAGS)

@xslim

This comment has been minimized.

Show comment Hide comment
@xslim

xslim Feb 24, 2013

Contributor

interesting idea - needs checking...

Contributor

xslim commented Feb 24, 2013

interesting idea - needs checking...

wearhere pushed a commit to inkling/Subliminal that referenced this pull request Apr 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment