Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rename to_plist methods on AbstractObject and ObjectDictionary #59

Merged
merged 1 commit into from Apr 3, 2013

Conversation

Projects
None yet
3 participants
Member

mtitolo commented Mar 26, 2013

Since the to_plist methods don't actually create a plist you can write directly to a file, it should not be named as such. Fixes CocoaPods/cocoapods.github.com#11

Note: This breaks backwards compatibility with anyone using to_plist since the method has been removed all together. Not sure if there's a depreciation plan for this.

Renamed to_plist to to_hash since it will always return a hash, and n…
…ot a valid plist string (XML, JSON or otherwise).
Owner

fabiopelosin commented Apr 3, 2013

Thanks for the pull! It looks good and can be merged as soon as the dust of the CocoaPods 0.17 release settles.

@fabiopelosin fabiopelosin merged commit 33e4d41 into CocoaPods:master Apr 3, 2013

1 check passed

default The Travis build passed
Details
Owner

fabiopelosin commented Apr 3, 2013

Just tested and CocoaPods is not affected by the changes of this patch.

@mtitolo mtitolo referenced this pull request in CocoaPods/cocoapods.github.com Apr 4, 2013

Closed

AbstractObject to_plist doesn't actually create a plist #11

Owner

alloy commented Apr 4, 2013

@mtitolo Thanks for you contributions! You now have commit access to all the CocoaPods tools repos and I’m also sending you an invitation to our Campfire channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment