Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check for command injections in the input for hg and git #124

Merged
merged 1 commit into from Mar 22, 2022

Conversation

orta
Copy link
Member

@orta orta commented Mar 22, 2022

It's possible to engineer a string which would cause the hg or git command to run shell commands, this has been blocked up in trunk already (CocoaPods/trunk.cocoapods.org#324) and this fixes it client-side

@dnkoutso
Copy link
Contributor

@dnkoutso dnkoutso commented Mar 22, 2022

Going to merge this and fix CI separately for Ruby 3.0

@dnkoutso dnkoutso merged commit b70bc39 into master Mar 22, 2022
4 of 5 checks passed
dnkoutso added a commit that referenced this issue Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants