Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches where we check for invalid input, to move it inside the download function #127

Merged
merged 1 commit into from Mar 28, 2022

Conversation

orta
Copy link
Member

@orta orta commented Mar 28, 2022

While CocoaPods would have seen this issue, moves the check into the core path of using the cocoapods-download api. We're supposed to assume clients would not always run the pre-process API:

      # preprocess download options
      #
      # Usage of this method is optional. concrete strategies should not
      # assume options are preprocessed for correct execution.
      #

@dnkoutso
Copy link
Contributor

@dnkoutso dnkoutso commented Mar 28, 2022

LGTM @orta want to do it for 1-6-stable so I can ship 1.6.3?

@orta orta changed the base branch from master to 1-6-stable Mar 28, 2022
@orta
Copy link
Member Author

@orta orta commented Mar 28, 2022

Hrm, tests passed locally, let's see what's up

@dnkoutso
Copy link
Contributor

@dnkoutso dnkoutso commented Mar 28, 2022

I think it was just rubocop

@dnkoutso dnkoutso merged commit d2564c3 into 1-6-stable Mar 28, 2022
5 checks passed
@dnkoutso dnkoutso deleted the validate_before_dl branch Mar 28, 2022
@dnkoutso dnkoutso restored the validate_before_dl branch Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants