Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches where we check for invalid input, to move it inside the download function #127

merged 1 commit into from Mar 28, 2022


Copy link

@orta orta commented Mar 28, 2022

While CocoaPods would have seen this issue, moves the check into the core path of using the cocoapods-download api. We're supposed to assume clients would not always run the pre-process API:

      # preprocess download options
      # Usage of this method is optional. concrete strategies should not
      # assume options are preprocessed for correct execution.

Copy link

LGTM @orta want to do it for 1-6-stable so I can ship 1.6.3?

@orta orta changed the base branch from master to 1-6-stable March 28, 2022 16:15
Copy link
Member Author

orta commented Mar 28, 2022

Hrm, tests passed locally, let's see what's up

Copy link

I think it was just rubocop

@dnkoutso dnkoutso merged commit d2564c3 into 1-6-stable Mar 28, 2022
@dnkoutso dnkoutso deleted the validate_before_dl branch March 28, 2022 16:20
@dnkoutso dnkoutso restored the validate_before_dl branch March 28, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants