Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the git pre-processor doesn't accidentally bail also #128

Merged
merged 1 commit into from Mar 31, 2022

Conversation

orta
Copy link
Member

@orta orta commented Mar 31, 2022

The refactor in #127 moved everything into the download path (as all API consumers would have to use that eventually) but self.preprocess_options can get called before that (and independently of it) and so this handles that case.

command = ['ls-remote',
'--',
Copy link
Member Author

@orta orta Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- was added to the version of git shipped with 2.25, but version 2.24 is still pretty actively used by default in osx as Apple Git-128 somewhere about 2 years ago - we shouldn't rely solely on the -- IMO

I'm trying to get an old git to test that this param is ignored ATM

@dnkoutso
Copy link
Contributor

@dnkoutso dnkoutso commented Mar 31, 2022

For 1-6-stable?

@orta orta changed the base branch from master to 1-6-stable Mar 31, 2022
@orta
Copy link
Member Author

@orta orta commented Mar 31, 2022

Yes, I'll fix rubocop after I get an old git to check

@orta
Copy link
Member Author

@orta orta commented Mar 31, 2022

Yep, good to go, confirmed the -- is ignored within a reasonable git range in an old linux vm:

image

@dnkoutso dnkoutso merged commit 52a0d54 into 1-6-stable Mar 31, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants