Update the list of known plugins #68

Closed
AliSoftware opened this Issue May 21, 2014 · 17 comments

Projects

None yet

5 participants

@AliSoftware

According to gem search "cocoapods-.*" some plugins are not listed in the plugins.json file:

  • cocoapods-icemobile-plugin (seems like a private plugin)
  • cocoapods-publisher (not a plugin despite the name)
  • cocoapods-repo-hg
  • cocoapods-roulette
  • cocoapods-search (not a plugin despite the name)
  • cocoapods-sorted-search
  • cocoapods-square-stable (not a plugin despite the name)

Additionally, cocoapods-try should be removed from the JSON list as it is a core plugin, installed by default.

/cc @dbgrandi

@orta
CocoaPods member

lets not put in useless ones, like the publisher and only include the better of search & sorted-search - at least for now we can curate to some extent

@AliSoftware

agreed.

I wonder if there is somewhere in pod plugins create a message reminding the author of a new plugin not to forget to add his/her plugin into the JSON here (via a PR)

@orta
CocoaPods member

good idea

@kylef

Perhaps it makes sense for the plugins JSON file to sit on a separate repository? This is kind of hidden away and not an expected place to find it.

@AliSoftware

Yep, I wonder why it was placed here at all.

I would have put it somewhere like in cocoapods-plugins repo itself, or in CocoaPods/shared or CocoaPods/CocoaPods itself, but not here.

@AliSoftware

Added related issues in CocoaPods/cocoapods-plugins.

@fabiopelosin
CocoaPods member

I think that it was placed here because it is served over the network.

@AliSoftware

@irrationalfab raw.githubusercontent.com is too 😄 so no need to host it in a website repo 😉

@fabiopelosin
CocoaPods member

GitHub's raw URLs aren't designed to be a generic web host. For example they don't send proper Content-Type headers. We can ignore it in our implementation but it can be a pain for other clients (for example based on AFNetworking). Also they can break in the future (e.g. rate limiting).

We can adapt quickly, so it is not a big deal, but having the choice it is better to properly host our assets. Having said that I'm fine with moving the file to CocoaPods/shared (even though I don't think that it improves visibility a lot) but I don't think that it should be moved to CocoaPods/CocoaPods. What about CocoaPods/cocoapods-plugins?

@AliSoftware AliSoftware self-assigned this May 22, 2014
@orta
CocoaPods member

We should move it out of the data folder actually, as I it's not accessible via the cocoapods.org interface, http://cocoapods.org/data/plugins.json

Should move to the root folder, thereby making it accessible via http://cocoapods.org/plugins.json

@AliSoftware

So at the root of cocoapods.org folder to make it served by CP.org?
Or in cocoapods-plugins repo to be consistent and not hidden away?
Let's vote ;)

@fabiopelosin
CocoaPods member

I vote for the root of cocoapods.org:

  • I don't think that in the cocoapods-plugins repo is much more visible.
  • I would be properly hosted.
  • We can create a webpage easily if one day we feel inclined to do so.
@dbgrandi

@AliSoftware cocoapods-search and cocoapods-publisher are not plugins. They are standalone scripts. cocoapods-sorted-search is cool.

👍 for root of cocoapods.org

@AliSoftware

Oh thx for the info @dbgrandi !
Should we suggest the authors to rename their gem then?

@dbgrandi

@AliSoftware CocoaPods is a big project. Some people might view suggesting other projects to rename as being kind of a bully. Unless it's causing a specific problem for CP users, I'd let them be.

@AliSoftware

Got it.

We should have used cocoapods-plugin as a prefix (or better, use cocoapods- as prefix + -plugin as suffix) from the start, but well it's probably kinda too late now, we are not gonna rename them all…

@AliSoftware AliSoftware added a commit that referenced this issue May 25, 2014
@AliSoftware AliSoftware Moved plugins.json from 'data/' to root dir (see #68 and CocoaPods/co…
…coapods-plugins#26). Added a temporary symlink so that cocoapods-plugins keeps working until next release.
0e714b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment