Add CocoaPush support to #36

wants to merge 14 commits into


None yet
5 participants

swizzlr commented Jan 24, 2014


This pull request is for discussion and implementation of a user interface for CocoaPush.

As I know nothing about design or frontend JS, I would appreciate input as to how it might work.

My current thinking is that the results, when hovered over, could have a button slide out that says "notify me". This will then add the pod to the user's list of desired pods, and, if necessary, initiate the request for permissions etc.

Through a runtime check for safari push notification permissions we can display a link at the top of the page, or on the page, to a small panel allowing the user to manage their settings: namely, to remove registered pods. Deregistration from push notifications should be done through Safari preferences.

This user settings page is keyed, unfortunately, on a per computer basis. Without a user account framework we are unable to share notifications or their settings between computers, but I believe the simplicity of no login is worth the tradeoff, both in technical debt and user experience.

cc @orta, as design dictator, and anyone else who knows JS.

Refer to this issue for tracking within cocoapush.


orta commented Jan 24, 2014

so, how I had imagined it:

If it's not been already been selected it stays a 50% opacity
screen shot 2014-01-24 at 15 47 15

hovering over it turns it 100% opacity and brings over a popover telling you what it'll do
screen shot 2014-01-24 at 15 51 09

clicking it makes the star dark ( and will register etc ) and then it switches to telling you what you have already starred
screen shot 2014-01-24 at 15 57 57


orta commented Jan 24, 2014

its a rough spec, and once there's something there then we can polish etc. Stars shouldn't show on non-safari browsers IMO, bit of a dick move to say "you should load this in safari" it's not 2002.

swizzlr commented Jan 24, 2014

Yep, definitely. What JS framework do we use?


orta commented Jan 24, 2014

jQuery, no frameworks. There's a template file here you can work from:

swizzlr commented Jan 25, 2014

Where did you get the stars from?

swizzlr commented Jan 25, 2014

screen shot 2014-01-25 at 11 04 51 pm
It's a start, though I'll need to fix the padding.

swizzlr commented Jan 26, 2014

Okay, as I have stubbed and commented, I'd like to make the stars rotate while a network request is processing – do you think that's a good idea?

If so, how would I go about animating it?

floere commented on f37d413 Jan 26, 2014

Can I suggest you move this from the search specific configuration to a separate JS file?


swizzlr replied Jan 26, 2014

Sure, how do I include it?


swizzlr commented on 0e24f69 Jan 27, 2014

@floere This is what you meant, yeah?

@swizzlr Exactly :)


orta commented Aug 18, 2014

wanna hack on this some this weekend or some evening @swizzlr ? ( /cc @segiddins you're welcome t come along too? )


segiddins commented Aug 19, 2014

I'd be more than happy to!

swizzlr commented Aug 19, 2014

@segiddins @orta Totally – this weekend perhaps? I'm pretty rammed this week.


orta commented Aug 20, 2014

The weekend is good for me, I have no plans, saturday midday at Artsy HQ?

swizzlr commented Aug 23, 2014

@orta @segiddins on for this

swizzlr commented Aug 23, 2014



kylef commented Jan 16, 2015

What's the state of this? /cc @swizzlr


orta commented Mar 17, 2015

Closing, happy to go through and the this running again but the site has moved considerably since this PR.

@orta orta closed this Mar 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment