Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue #179 #180

Merged
merged 1 commit into from May 4, 2012

Conversation

Projects
None yet
2 participants

drd27 commented May 3, 2012

When text is fully justified, the last line in a paragraph should be naturally aligned.

odrobnik added a commit that referenced this pull request May 4, 2012

@odrobnik odrobnik merged commit 35186f4 into Cocoanetics:master May 4, 2012

Collaborator

odrobnik commented May 4, 2012

Great job!

JasonLion added a commit to JasonLion/DTCoreText that referenced this pull request Jun 28, 2012

Prevent justification of the final lines of paragraphs
Justify is still justifying the last line of some paragraphs, despite
pull request #180/ issue #179.

There are two bugs. First, the calculation of isAtEndOfParagraph on
line 172 of DTCoreTextLayoutFrame.m is wrong, checking to see if the
line starts at the end of the paragraph. Second, a br doesn't end the
paragraph but should suppress justification as if it was the end of the
paragraph.

Both issues are solved with this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment