Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Margins for Spacings on Paragraphs #258

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

gamma commented Dec 20, 2012

The paragraph defines several spacing options that need to be converted to margins. This will very likely make the htmlString a lot larger - so it should somehow be put into a css style tag.

@gamma gamma Added margins for corresponding spacing options
The paragraph defines several spacing options that need to be converted to margins. This will very likely make the htmlString a lot larger - so it should somehow be put into a css style tag.
3a6c6ef

@gamma I believe that there is a mistake: We have all spacings in pixels, not em units as you are have them. Also _headIndent should be margin-left, not _paragraphSpacingBefore. And while you are at it, also add _tailIndent which is margin-right.

Owner

gamma replied Dec 20, 2012

Shure.

Owner

gamma replied Dec 20, 2012

There is another one assumption I made: margin-bottom and top will be set if the value is not "1" - while left and right must be different from "0". The reason for this is the default value DTCoreText uses. This way I can add margin-top/bottom:0. Is this correct?

gamma added some commits Dec 20, 2012

@gamma gamma Error and added margin-right
The headIndent accidentally used the value of _paragraphSpacingBefore. _tailIndent is now available as well.
3c182a3
@gamma gamma Added margin-right
_tailIndent for margin-right has been added.
5683a20
Collaborator

odrobnik commented Dec 20, 2012

@gamma sorry, I cannot marge this because I already pulled the first commit and made the necessary corrections.

Please discard your local changes and update to the latest master version.

@odrobnik odrobnik closed this Dec 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment