Accumulate characters in DTHTMLParser to avoid reporting characters to f...

[JayZhao]

...requently.

[odrobnik]

Please rename the internal methods with an underscore prefix.

[odrobnik]

Also please follow our coding style of having opening curly braces always on a new line, also for if and else.

[odrobnik]

Did you test that all unit tests in DTCoreText for iOS and Mac still pass?

[JayZhao]

Sorry I didn't run the test.

I try to do that just now and run into this link error:
Undefined symbols for architecture i386:
"OBJC_CLASS$_DTASN1Serialization", referenced from:
objc-class-ref in DTASN1SerializationTest.o
(maybe you meant: OBJC_CLASS$_DTASN1SerializationTest)
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Both in XCode 5 and XCode 4.

I did tested the DemoApp and my project, worked perfectly.

[odrobnik]

That's the wrong unit tests. (though it seems that you found a 1.5 knock-on effect which I need to fix)

You should run the UnitTest (iOS) and MacUnitTest tests in DTCoreText.

On Aug 1, 2013, at 6:17 PM, JayZhao notifications@github.com wrote:

Sorry I didn't run the test.

I try to do that just now and run into this link error:
Undefined symbols for architecture i386:
"OBJC_CLASS$_DTASN1Serialization", referenced from:
objc-class-ref in DTASN1SerializationTest.o
(maybe you meant: OBJC_CLASS$_DTASN1SerializationTest)
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Both in XCode 5 and XCode 4.

I did tested the DemoApp and my project, worked perfectly.

—
Reply to this email directly or view it on GitHub.

[JayZhao]

Ha, It seems the test targets are not listed in project schemes. I found them in the product folder and duplicated them so XCode automatically create two scheme for them.
Yes, all tests are green.

[odrobnik]

@JayZhao please NEVER create pull requests from master to master. Create a branch off develop to contain your changes, push this branch to your fork and then make a pull request from this feature_branch to develop

[odrobnik]

I did a manual merge into develop at 1d9baa4.

[JayZhao]

Got it, thank you for pointing out the pull request workflow.