New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorings in Receipt_chain_database #1119

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
2 participants
@johnwu93
Contributor

johnwu93 commented Nov 9, 2018

  • Changed transactions to payments to be aligned to our terminologies
  • Change the name of the module to receipt_chain_database_lib. We will
    instantiate it later in Coda_main.
    Renaming is to avoid name shadowing when instantiating

Checklist:

  • Tests were added for the new behavior
  • All tests pass (CI will check this if you didn't)
  • Does this close issues? List them:

@johnwu93 johnwu93 force-pushed the refactoring/receipt_chain_database branch from c4bcec4 to a12c231 Nov 9, 2018

Refactorings in Receipt_chain_database
- Changed transactions to payments to be aligned to our terminologies
- Change name of module to receipt_chain_database_lib. We will
instantiate it later in Coda_main.
Renaming is to avoid name shadowing when insantiating

@johnwu93 johnwu93 force-pushed the refactoring/receipt_chain_database branch from a12c231 to b5a0776 Nov 9, 2018

@bkase

bkase approved these changes Nov 10, 2018

@johnwu93 johnwu93 merged commit 972c66b into master Nov 12, 2018

8 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_public Your tests passed on CircleCI!
Details
ci/circleci: build_withsnark Your tests passed on CircleCI!
Details
ci/circleci: test-all_sig_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: test-all_stake_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: test-unit-test Your tests passed on CircleCI!
Details
ci/circleci: test-withsnark Your tests passed on CircleCI!
Details

@cmr cmr deleted the refactoring/receipt_chain_database branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment