Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/use delegate vrf evals #1148
This PR does 2 things.
I'm a little bit confused about the
Prover_state stuff. Perhaps I'm missing something, but it looks like you define Prover_state for proof of stake to be rather large, and then stuff it into
Snark_transition, which is the layer of
Internal_transition which is used as an input into the snark. How is
prover_state even used on
Your changes look good, but there's one more issue I noticed to address and then I will approve.
Looks pretty good, so I'm approving. Just two more optional asks before you merge:
- The old code used to ensure that the epoch ledger we check for vrfs has the hash stored in the consensus state. It would be nice if you could add a debug assert that still ensures this is true when evaluating the vrf.
- Check my comment about the binable private key.