New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold new transition frontier #1163

Merged
merged 6 commits into from Nov 17, 2018

Conversation

Projects
None yet
2 participants
@nholland94
Contributor

nholland94 commented Nov 16, 2018

This will serve as the basis for implementing the new transition frontier datastructure and the components in the system which handle network interactions with the datastructure.

This PR creates the libraries where the code will live, defines the signatures of the components, and includes a top level library which will compose the components together. The actual frontier datastructure interface is not fully designed as of right now since the explicit requirements around its interface will be informed by the implementation of the other components which interact with it.

@nholland94 nholland94 requested a review from bkase Nov 16, 2018

@bkase

bkase approved these changes Nov 17, 2018

Can you add jbuilds and .opams for all the libs also? Otherwise, looks good

@@ -1,5 +1,6 @@
open Core_kernel
open Async_kernel
include Coda_transition_frontier

This comment has been minimized.

@bkase

bkase Nov 17, 2018

Contributor

you didn't even need coda_pow0.ml!

@nholland94 nholland94 force-pushed the feature/transition_frontier_scaffold branch from eda733e to 339f2f0 Nov 17, 2018

@nholland94 nholland94 force-pushed the feature/transition_frontier_scaffold branch from 339f2f0 to 55b4ca6 Nov 17, 2018

@bkase

This comment has been minimized.

Contributor

bkase commented Nov 17, 2018

As discussed, feel free to land without adding jbuilds and opam files

bkase and others added some commits Nov 17, 2018

@nholland94 nholland94 merged commit e38704a into master Nov 17, 2018

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_public Your tests passed on CircleCI!
Details
ci/circleci: build_withsnark Your tests passed on CircleCI!
Details
ci/circleci: test-all_sig_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: test-all_stake_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: test-unit-test Your tests passed on CircleCI!
Details
ci/circleci: test-withsnark Your tests passed on CircleCI!
Details
ci/circleci: tracetool Your tests passed on CircleCI!
Details

@nholland94 nholland94 deleted the feature/transition_frontier_scaffold branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment