New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/snarky curves lib #1393

Merged
merged 8 commits into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@imeckler
Copy link
Contributor

imeckler commented Jan 4, 2019

Pulls out the snarky/curves.ml module into a separate library and generalizes it to curves over arbitrary fields.

I did not remove snarky/curves.ml yet as snarky/gm_verifier_gadget.ml depends on it and I didn't want to go through the trouble of then pulling out that into its own library when I'm going to remove it soon anyway.

imeckler added some commits Jan 4, 2019

@mrmr1993
Copy link
Contributor

mrmr1993 left a comment

Nice!

Would it be worth removing it from snarky/snark.ml now, if this isn't officially part of Snarky any more?

imeckler added some commits Jan 5, 2019

@imeckler imeckler merged commit fffe14d into master Jan 10, 2019

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_public Your tests passed on CircleCI!
Details
ci/circleci: build_withsnark Your tests passed on CircleCI!
Details
ci/circleci: test-all_sig_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: test-all_stake_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: test-unit-test Your tests passed on CircleCI!
Details
ci/circleci: test-withsnark Your tests passed on CircleCI!
Details
ci/circleci: tracetool Your tests passed on CircleCI!
Details

@imeckler imeckler deleted the feature/snarky-curves-lib branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment