Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix groth16 gamma removal #1416
Conversation
imeckler
added some commits
Jan 9, 2019
bkase
approved these changes
Jan 9, 2019
imeckler
merged commit 494b0c5
into
master
Jan 9, 2019
8 checks passed
ci/circleci: build
Your tests passed on CircleCI!
Details
ci/circleci: build_public
Your tests passed on CircleCI!
Details
ci/circleci: build_withsnark
Your tests passed on CircleCI!
Details
ci/circleci: test-all_sig_integration_tests
Your tests passed on CircleCI!
Details
ci/circleci: test-all_stake_integration_tests
Your tests passed on CircleCI!
Details
ci/circleci: test-unit-test
Your tests passed on CircleCI!
Details
ci/circleci: test-withsnark
Your tests passed on CircleCI!
Details
ci/circleci: tracetool
Your tests passed on CircleCI!
Details
imeckler
deleted the
fix/groth16-gamma-removal
branch
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
imeckler commentedJan 9, 2019
This fixes an error I made in removing gamma, wherein it was not fully removed.