New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failwith on bootstrap clean #1475

merged 3 commits into from Jan 18, 2019
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+10 −8
Diff settings


Just for now

@@ -82,7 +82,7 @@ module Make (Inputs : Inputs_intf) :
let create_bufferred_pipe () =
Strict_pipe.create (Buffered (`Capacity 10, `Overflow Drop_head))

let kill reader writer =
let _kill reader writer =
Strict_pipe.Reader.clear reader ;
Strict_pipe.Writer.close writer

@@ -114,7 +114,7 @@ module Make (Inputs : Inputs_intf) :
let get {var; _} = var

let set_bootstrap_phase ~controller_type root_state
let _set_bootstrap_phase ~controller_type root_state
bootstrap_controller_writer =
assert (not @@ is_bootstrapping (Broadcaster.get controller_type)) ;
Broadcaster.broadcast controller_type
@@ -126,13 +126,15 @@ module Make (Inputs : Inputs_intf) :
Broadcaster.broadcast controller_type
(`Transition_frontier_controller (new_frontier, reader, writer))

let run ~logger ~network ~time_controller ~frontier_mvar ~ledger_db
let run ~logger ~network ~time_controller ~frontier_mvar ~ledger_db:_
~network_transition_reader ~proposer_transition_reader =
let clean_transition_frontier_controller_and_start_bootstrap
~controller_type ~clear_writer ~transition_frontier_controller_reader
~transition_frontier_controller_writer ~old_frontier
(`Transition incoming_transition, `Time_received tm) =
kill transition_frontier_controller_reader
~controller_type:_ ~clear_writer:_
~transition_frontier_controller_writer:_ ~old_frontier:_
(`Transition _incoming_transition, `Time_received _tm) =
failwith "Bootstrap is disabled as there this an infinite loop here"
(* kill transition_frontier_controller_reader
transition_frontier_controller_writer ;
Strict_pipe.Writer.write clear_writer `Clear |> don't_wait_for ;
let bootstrap_controller_reader, bootstrap_controller_writer =
@@ -152,7 +154,7 @@ module Make (Inputs : Inputs_intf) :
kill bootstrap_controller_reader bootstrap_controller_writer ;
new_frontier *)
let start_transition_frontier_controller ~verified_transition_writer
~clear_reader frontier =
ProTip! Use n and p to navigate between commits in a pull request.