Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A one-line change for the integration test of ledger catchup and another one-line change in ledger_catchup itself #1819

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@ghost-not-in-the-shell
Copy link
Contributor

ghost-not-in-the-shell commented Mar 8, 2019

In this PR, I made 2 changes:

  1. I make the test time for ledger catchup to 4 min instead of 30 sec.
  2. I delete the unnecessary Breadcrumb.copy in ledger catchup.

For 2, copy is unwanted because it would create extra layers of mask, which may cause move-root to fail. And since we already did the checks for dangling mask, we don't have to make a copy anyway.

@bkase

bkase approved these changes Mar 8, 2019

@mergify mergify bot merged commit c60b07b into master Mar 9, 2019

15 of 16 checks passed

ci/circleci: build-macos CircleCI is running your tests
Details
ci/circleci: build-wallet Your tests passed on CircleCI!
Details
ci/circleci: build_dev Your tests passed on CircleCI!
Details
ci/circleci: build_testnet_posig Your tests passed on CircleCI!
Details
ci/circleci: build_testnet_postake Your tests passed on CircleCI!
Details
ci/circleci: build_testnet_postake_snarkless_fake_hash Your tests passed on CircleCI!
Details
ci/circleci: build_testnet_public Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test-fake_hash_full_test Your tests passed on CircleCI!
Details
ci/circleci: test-posig_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: test-postake_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: test-postake_split_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: test-unit-test Your tests passed on CircleCI!
Details
ci/circleci: test-withsnark-sig Your tests passed on CircleCI!
Details
ci/circleci: test-withsnark-stake Your tests passed on CircleCI!
Details
ci/circleci: tracetool Your tests passed on CircleCI!
Details

@mergify mergify bot deleted the test/ledger-catchup-integration-test branch Mar 9, 2019

@ghost-not-in-the-shell ghost-not-in-the-shell restored the test/ledger-catchup-integration-test branch Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.