Coinbase in snark: coinbase split and no coinbase cases #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthiskumar
changed the title
…s need to be added in the unchecked version
imeckler
requested changes
Mar 26, 2019
| Currency.Amount.var_of_t Protocols.Coda_praos.coinbase_amount | ||
| in | ||
| let%bind rem_amount, `Underflow underflowed = | ||
| Currency.Amount.Checked.sub_flagged total_coinbase_amount amount |
There was a problem hiding this comment.
No need to use sub_flagged if you are going to assert there is no underflow.
| let%bind amount2_equal_to_zero = equal_to_zero rem_amount in | ||
| let%bind stack_with_amount1 = | ||
| Coinbase_stack.Stack.Checked.push stack | ||
| (pk, Amount.Signed.Checked.of_unsigned amount) |
There was a problem hiding this comment.
There is an opportunity to save a lot of hashing here. Hashing a public key is about 1000 constraints and that could be shared between the two pushes. Maybe make an issue with an 'optimization' label
imeckler
approved these changes
Mar 28, 2019
deepthiskumar
added a commit
that referenced
this pull request
Mar 29, 2019
Implements in-SNARK check for coinbases. How: 1) A transaction snark now has a set of coinbases (`Pending_coinbase.Stack`) that it includes. 2) Maintain a collection of coinbases included so far and subtract from it, the set of coinbases included in a ledger proof. This collection called `Pending coinbases` represents all the coinbases that are yet to be included in ledger proofs. In blockchain snark, a new coinbase is added and the set of coinbases included in a ledger proof is subtracted. Also, handles the cases (#1936) 1) when there is no coinbase included in the transition 2) when a coinbase is split into two parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the following two cases when checking pending coinbases in blockchain snark