Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace participated with voting_for in Account.t #2356

Merged
merged 11 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@ghost-not-in-the-shell
Copy link
Contributor

commented Apr 30, 2019

This PR did 2 things:

  1. replaced the participated:bool field with voting_for:state_hash in Account.t;
  2. created a lib for smallest out of scope field element

@ghost-not-in-the-shell ghost-not-in-the-shell force-pushed the feature/new-user-command-vote branch from b06f5ac to 8838116 May 1, 2019

@ghost-not-in-the-shell ghost-not-in-the-shell changed the title [WIP] Feature/new user command vote Replace `participated` with `voting_for` in `Account.t` May 1, 2019

@ghost-not-in-the-shell ghost-not-in-the-shell changed the title Replace `participated` with `voting_for` in `Account.t` Replace participated with voting_for in Account.t May 1, 2019

@imeckler
Copy link
Contributor

left a comment

a few comments

@@ -204,11 +204,12 @@ module Make (Commands : Coda_commands.Intf) = struct
~args:Arg.[]
~resolve:(fun _ account ->
Stringable.public_key account.Account.Poly.delegate )
; field "participated" ~typ:(non_null bool)
; field "votingFor" ~typ:(non_null string)
~doc:"TODO, not sure what this is"

This comment has been minimized.

Copy link
@imeckler

imeckler May 1, 2019

Contributor

Can you add a good doc here?

=
let%map public_key = Public_key.Compressed.var_to_triples public_key
let%bind public_key = Public_key.Compressed.var_to_triples public_key

This comment has been minimized.

Copy link
@imeckler

imeckler May 1, 2019

Contributor

It doesn't matter but just fyi you can include the voting_for in the %map using and.

(preprocessor_deps ../../../config.mlh)
(preprocess
(pps ppx_jane ppxlib.metaquot))
(flags -w -40 -g -warn-error

This comment has been minimized.

Copy link
@imeckler

imeckler May 1, 2019

Contributor

Do you need all these warnings turned off?

(name gen_values)
(libraries async core snark_params
ppxlib ppx_util)
(preprocessor_deps ../../../config.mlh)

This comment has been minimized.

Copy link
@imeckler

imeckler May 1, 2019

Contributor

Do you need config.mlh?

@@ -0,0 +1,14 @@
(library
(name null_field_element)

This comment has been minimized.

Copy link
@imeckler

imeckler May 1, 2019

Contributor

I think we should have a somewhat more descriptive name. Maybe like non_curve_x_coordinate or outside_pedersen_image or something?

ghost-not-in-the-shell and others added some commits May 2, 2019

@jkrauska

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

@ghost-not-in-the-shell can you resolve the lite_compat conflict?

@mergify mergify bot merged commit 9368f8a into master May 3, 2019

19 of 20 checks passed

ci/circleci: test--test_postake_holy_grail Your tests failed on CircleCI
Details
Summary 1 rule matches
Details
ci/circleci: build-artifacts--testnet_postake Your tests passed on CircleCI!
Details
ci/circleci: build-artifacts--testnet_postake_many_proposers Your tests passed on CircleCI!
Details
ci/circleci: build-artifacts--testnet_postake_snarkless_fake_hash Your tests passed on CircleCI!
Details
ci/circleci: build-wallet Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test--fake_hash Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_bootstrap Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_catchup Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_txns Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_txns Your tests passed on CircleCI!
Details
ci/circleci: test-unit--dev Your tests passed on CircleCI!
Details
ci/circleci: test-unit--test_postake_snarkless Your tests passed on CircleCI!
Details
ci/circleci: tracetool Your tests passed on CircleCI!
Details

@mergify mergify bot deleted the feature/new-user-command-vote branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.